Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the close operation of rmq consumer is not sync #38734

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Dec 25, 2024

issue: #38399

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 25, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh
To complete the pull request process, please assign tedxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @tedxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 25, 2024
Copy link
Contributor

mergify bot commented Dec 25, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.33%. Comparing base (acc8fb7) to head (e08434f).
Report is 4 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (acc8fb7) and HEAD (e08434f). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (acc8fb7) HEAD (e08434f)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38734       +/-   ##
===========================================
- Coverage   81.08%   69.33%   -11.75%     
===========================================
  Files        1381      292     -1089     
  Lines      195251    26182   -169069     
===========================================
- Hits       158321    18154   -140167     
+ Misses      31345     8028    -23317     
+ Partials     5585        0     -5585     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.33% <ø> (ø)
Go ∅ <ø> (∅)

see 1089 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Dec 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants