Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix complie error generated by conflict pr #38729

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Dec 25, 2024

issue: #38399

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 25, 2024
@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Dec 25, 2024
@yanliang567
Copy link
Contributor

manual pass to unblock compiling issue

@MrPresent-Han
Copy link
Contributor

/lgtm

@czs007
Copy link
Collaborator

czs007 commented Dec 25, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 05d9f85 into milvus-io:master Dec 25, 2024
8 of 11 checks passed
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.07%. Comparing base (118678b) to head (e7e413e).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38729       +/-   ##
===========================================
+ Coverage   69.33%   81.07%   +11.73%     
===========================================
  Files         292     1381     +1089     
  Lines       26187   195194   +169007     
===========================================
+ Hits        18158   158245   +140087     
- Misses       8029    31351    +23322     
- Partials        0     5598     +5598     
Components Coverage Δ
Client 78.26% <ø> (∅)
Core 69.33% <ø> (ø)
Go 83.05% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/util/streamingutil/util/wal_selector.go 100.00% <100.00%> (ø)

... and 1088 files with indirect coverage changes

@chyezh chyezh deleted the fix_compile_error branch December 25, 2024 03:15
NicoYuan1986 pushed a commit to NicoYuan1986/milvus that referenced this pull request Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants