Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: report error when hints not supported #38717

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chasingegg
Copy link
Contributor

issue: #38705

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 24, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chasingegg
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 24, 2024
Signed-off-by: chasingegg <[email protected]>
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.01%. Comparing base (636e107) to head (7d6298e).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38717      +/-   ##
==========================================
- Coverage   81.03%   81.01%   -0.03%     
==========================================
  Files        1380     1380              
  Lines      195154   195157       +3     
==========================================
- Hits       158145   158108      -37     
- Misses      31438    31461      +23     
- Partials     5571     5588      +17     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.34% <100.00%> (+<0.01%) ⬆️
Go 82.99% <ø> (-0.03%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/query/PlanProto.cpp 90.37% <100.00%> (+0.09%) ⬆️

... and 24 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants