fix: [2.4] Querycoord will trigger unexpected balance task after restart #38714
+129
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sre-ci-robot
added
area/internal-api
size/S
mergify
bot
added
dco-passed
weiliu1031
changed the title
weiliu1031
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #38714 +/- ##
==========================================
- Coverage 83.40% 79.52% -3.89%
==========================================
Files 809 1077 +268
Lines 143068 169590 +26522
==========================================
+ Hits 119333 134859 +15526
- Misses 19243 30242 +10999
+ Partials 4492 4489 -3
|
Signed-off-by: Wei Liu <[email protected]>
weiliu1031
force-pushed
the
fix_balance_after_qc_restarts24
branch
from
5241ae8 to
3cd369d
Compare
sre-ci-robot
added
size/L
chyezh
reviewed
Dec 24, 2024
tedxu
reviewed
Dec 24, 2024
| return !b.targetMgr.IsCurrentTargetReady(cid) | ||
| }) | ||
| if len(notReadyCollections) > 0 { | ||
| log.RatedInfo(10, "skip normal balance, cause collection not ready for balance", zap.Int64s("collectionIDs", notReadyCollections)) |
There was a problem hiding this comment.
There is no need to log all collections here.
Signed-off-by: Wei Liu <[email protected]>
weiliu1031
force-pushed
the
fix_balance_after_qc_restarts24
branch
from
3cd369d to
12eb029
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: weiliu1031 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #38606
pr: #38630