Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] fix privilege group list and list collections #38698

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

shaoting-huang
Copy link
Contributor

cherry-pick from: #38684
related: #37031

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 24, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug ci-passed labels Dec 24, 2024
@sre-ci-robot sre-ci-robot added area/test sig/testing test/integration integration test size/L Denotes a PR that changes 100-499 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Dec 25, 2024
@mergify mergify bot removed the ci-passed label Dec 25, 2024
Copy link
Contributor

mergify bot commented Dec 25, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 98.24561% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.42%. Comparing base (648078e) to head (3c12262).
Report is 4 commits behind head on 2.4.

Files with missing lines Patch % Lines
pkg/util/paramtable/rbac_param.go 98.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38698      +/-   ##
==========================================
- Coverage   83.40%   80.42%   -2.99%     
==========================================
  Files         809     1077     +268     
  Lines      143068   169597   +26529     
==========================================
+ Hits       119333   136404   +17071     
- Misses      19243    28708    +9465     
+ Partials     4492     4485       -7     
Files with missing lines Coverage Δ
internal/rootcoord/root_coord.go 87.58% <100.00%> (-0.14%) ⬇️
internal/rootcoord/show_collection_task.go 100.00% <100.00%> (ø)
pkg/util/constant.go 96.82% <ø> (ø)
pkg/util/paramtable/rbac_param.go 99.23% <98.00%> (-0.77%) ⬇️

... and 297 files with indirect coverage changes

@tedxu
Copy link
Contributor

tedxu commented Dec 25, 2024

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shaoting-huang, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ef6aae8 into milvus-io:2.4 Dec 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants