Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix directory confusion between indexnode and querynode #38628

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Dec 20, 2024

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhagnlu
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 20, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 20, 2024
@zhagnlu zhagnlu force-pushed the fix_local_chunk_manager branch 4 times, most recently from 55656c5 to 2f9bca9 Compare December 20, 2024 09:55
Copy link
Contributor

mergify bot commented Dec 20, 2024

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 20, 2024

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 20, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 23, 2024

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@zhagnlu zhagnlu force-pushed the fix_local_chunk_manager branch from 2f9bca9 to ac55af4 Compare December 25, 2024 12:30
Copy link
Contributor

mergify bot commented Dec 25, 2024

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 25, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 27 lines in your changes missing coverage. Please review.

Project coverage is 69.28%. Comparing base (3d360c0) to head (ac55af4).
Report is 38 commits behind head on master.

Current head ac55af4 differs from pull request most recent head b314cb5

Please upload reports for the commit b314cb5 to get more accurate results.

Files with missing lines Patch % Lines
internal/core/src/common/Common.h 0.00% 10 Missing ⚠️
internal/core/src/storage/DiskFileManagerImpl.cpp 66.66% 7 Missing ⚠️
internal/core/src/storage/storage_c.cpp 20.00% 4 Missing ⚠️
internal/core/src/index/VectorDiskIndex.cpp 50.00% 2 Missing ⚠️
internal/core/src/segcore/load_index_c.cpp 0.00% 2 Missing ⚠️
...rnal/core/src/storage/LocalChunkManagerSingleton.h 88.88% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38628      +/-   ##
==========================================
- Coverage   69.35%   69.28%   -0.08%     
==========================================
  Files         292      292              
  Lines       26189    26220      +31     
==========================================
+ Hits        18163    18166       +3     
- Misses       8026     8054      +28     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.28% <57.14%> (-0.08%) ⬇️
Go ∅ <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/index/InvertedIndexTantivy.cpp 92.64% <100.00%> (ø)
internal/core/src/storage/DiskFileManagerImpl.h 60.00% <ø> (ø)
internal/core/src/storage/MmapChunkManager.cpp 84.00% <100.00%> (ø)
internal/core/src/index/VectorDiskIndex.cpp 78.01% <50.00%> (ø)
internal/core/src/segcore/load_index_c.cpp 34.32% <0.00%> (ø)
...rnal/core/src/storage/LocalChunkManagerSingleton.h 90.00% <88.88%> (-10.00%) ⬇️
internal/core/src/storage/storage_c.cpp 58.10% <20.00%> (-8.09%) ⬇️
internal/core/src/storage/DiskFileManagerImpl.cpp 55.55% <66.66%> (+0.49%) ⬆️
internal/core/src/common/Common.h 9.09% <0.00%> (-90.91%) ⬇️

... and 16 files with indirect coverage changes

@zhagnlu zhagnlu force-pushed the fix_local_chunk_manager branch from ac55af4 to b314cb5 Compare December 26, 2024 00:21
Copy link
Contributor

mergify bot commented Dec 26, 2024

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 26, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 26, 2024

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants