Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: need pass parameter to listPrivilegeGroups #38562

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

smellthemoon
Copy link
Contributor

@smellthemoon smellthemoon commented Dec 18, 2024

issue: #38563

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 18, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 18, 2024
Copy link
Contributor

mergify bot commented Dec 18, 2024

@smellthemoon Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Dec 18, 2024

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@smellthemoon
Copy link
Contributor Author

rerun go-sdk

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.98%. Comparing base (894c203) to head (0faeb80).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38562       +/-   ##
===========================================
+ Coverage   69.32%   80.98%   +11.65%     
===========================================
  Files         292     1379     +1087     
  Lines       26183   194361   +168178     
===========================================
+ Hits        18152   157407   +139255     
- Misses       8031    31403    +23372     
- Partials        0     5551     +5551     
Components Coverage Δ
Client 75.27% <ø> (∅)
Core 69.32% <ø> (+<0.01%) ⬆️
Go 83.03% <100.00%> (∅)
Files with missing lines Coverage Δ
...nternal/distributed/proxy/httpserver/handler_v2.go 92.58% <100.00%> (ø)

... and 1087 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Dec 18, 2024

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@yanliang567 yanliang567 modified the milestones: 2.4.18, 2.5.0 Dec 18, 2024
@smellthemoon
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Dec 18, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@tedxu
Copy link
Contributor

tedxu commented Dec 18, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smellthemoon, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 134d06f into milvus-io:master Dec 18, 2024
20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants