Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert optimize CPU usage for CheckHealth requests (#35589) #38555

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

jaime0815
Copy link
Contributor

@jaime0815 jaime0815 commented Dec 18, 2024

issue: #35563

@sre-ci-robot sre-ci-robot added area/internal-api size/XXL Denotes a PR that changes 1000+ lines. labels Dec 18, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Dec 18, 2024
Copy link
Contributor

mergify bot commented Dec 18, 2024

@jaime0815

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@jaime0815 jaime0815 added this to the 2.5.0 milestone Dec 18, 2024
@jaime0815 jaime0815 changed the title Revert "enhance: optimize CPU usage for CheckHealth requests (#35589)" fix: "revert optimize CPU usage for CheckHealth requests (#35589)" Dec 18, 2024
@jaime0815 jaime0815 changed the title fix: "revert optimize CPU usage for CheckHealth requests (#35589)" fix: revert optimize CPU usage for CheckHealth requests (#35589) Dec 18, 2024
@mergify mergify bot added kind/bug Issues or changes related a bug and removed do-not-merge/invalid-pr-format labels Dec 18, 2024
Copy link
Contributor

mergify bot commented Dec 18, 2024

@jaime0815 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 18, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@jaime0815
Copy link
Contributor Author

rerun cpp-unit-test

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@jaime0815
Copy link
Contributor Author

rerun cpp-unit-test

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 85.85859% with 28 lines in your changes missing coverage. Please review.

Project coverage is 80.96%. Comparing base (134d06f) to head (6744f7d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/rootcoord/util.go 87.50% 6 Missing and 3 partials ⚠️
internal/querycoordv2/utils/util.go 50.00% 7 Missing ⚠️
internal/rootcoord/root_coord.go 85.71% 3 Missing and 1 partial ⚠️
internal/datacoord/session/datanode_manager.go 75.00% 2 Missing and 1 partial ⚠️
internal/querynodev2/metrics_info.go 40.00% 2 Missing and 1 partial ⚠️
internal/querycoordv2/services.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38555      +/-   ##
==========================================
- Coverage   81.00%   80.96%   -0.05%     
==========================================
  Files        1379     1378       -1     
  Lines      194455   194255     -200     
==========================================
- Hits       157527   157269     -258     
- Misses      31388    31426      +38     
- Partials     5540     5560      +20     
Components Coverage Δ
Client 75.27% <ø> (ø)
Core 69.32% <ø> (ø)
Go 83.00% <85.85%> (-0.06%) ⬇️
Files with missing lines Coverage Δ
internal/datacoord/server.go 73.22% <ø> (-0.18%) ⬇️
internal/datacoord/services.go 85.63% <100.00%> (-0.04%) ⬇️
internal/datacoord/util.go 98.68% <100.00%> (ø)
internal/datanode/metrics_info.go 96.20% <100.00%> (ø)
internal/datanode/services.go 85.01% <ø> (-0.48%) ⬇️
internal/distributed/datanode/client/client.go 89.67% <ø> (-0.26%) ⬇️
internal/distributed/datanode/service.go 82.50% <ø> (-0.15%) ⬇️
internal/distributed/querynode/client/client.go 91.55% <ø> (-0.15%) ⬇️
internal/distributed/querynode/service.go 83.56% <ø> (-0.15%) ⬇️
...nternal/flushcommon/pipeline/flow_graph_manager.go 91.20% <100.00%> (-0.88%) ⬇️
... and 18 more

... and 31 files with indirect coverage changes

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@jaime0815
Copy link
Contributor Author

rerun cpp-unit-test

1 similar comment
@jaime0815
Copy link
Contributor Author

rerun cpp-unit-test

@mergify mergify bot added the ci-passed label Dec 18, 2024
@jaime0815 jaime0815 force-pushed the revert-health-refine branch from 0b659a1 to 6744f7d Compare December 18, 2024 12:32
@mergify mergify bot removed the ci-passed label Dec 18, 2024
Copy link
Contributor

mergify bot commented Dec 18, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@czs007
Copy link
Collaborator

czs007 commented Dec 18, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Dec 18, 2024
@sre-ci-robot sre-ci-robot merged commit 78438ef into milvus-io:master Dec 18, 2024
19 of 20 checks passed
@jaime0815 jaime0815 deleted the revert-health-refine branch December 19, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/internal-api ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants