Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support get segments from current segments view #38512

Merged
merged 1 commit into from
Dec 18, 2024
Merged

fix: Support get segments from current segments view #38512

merged 1 commit into from
Dec 18, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #38511

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 17, 2024
@yanliang567 yanliang567 added this to the 2.5.0 milestone Dec 17, 2024
@xiaocai2333 xiaocai2333 force-pushed the get_current_segment_view branch from 6088b20 to cf3dad4 Compare December 17, 2024 04:58
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 17, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

rerun go-sdk

@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.40260% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.98%. Comparing base (894c203) to head (c396228).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
internal/datacoord/handler.go 97.87% 1 Missing and 1 partial ⚠️
internal/datacoord/services.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38512       +/-   ##
===========================================
+ Coverage   69.32%   80.98%   +11.65%     
===========================================
  Files         292     1379     +1087     
  Lines       26183   194438   +168255     
===========================================
+ Hits        18152   157456   +139304     
- Misses       8031    31425    +23394     
- Partials        0     5557     +5557
Components Coverage Δ
Client 75.27% <ø> (∅)
Core 69.32% <ø> (ø)
Go 83.02% <97.40%> (∅)
Files with missing lines Coverage Δ
internal/datacoord/partition_stats_meta.go 47.16% <100.00%> (ø)
internal/datacoord/sync_segments_scheduler.go 100.00% <100.00%> (ø)
internal/datacoord/handler.go 79.74% <97.87%> (ø)
internal/datacoord/services.go 85.67% <77.77%> (ø)

... and 1083 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 17, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333 xiaocai2333 force-pushed the get_current_segment_view branch from cf3dad4 to 538ce3c Compare December 17, 2024 08:10
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 17, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

liliu-z
liliu-z reviewed Dec 17, 2024
View reviewed changes
internal/datacoord/services.go Outdated
Comment on lines 1044 to 1046
} else {
segmentIDs = s.meta.GetSegmentsIDOfPartition(ctx, collectionID, partitionID)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dup？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, removed it.

@mergify mergify bot added ci-passed and removed ci-passed labels Dec 17, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 18, 2024

/approve

@sre-ci-robot sre-ci-robot added approved size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Dec 18, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 18, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333 xiaocai2333 force-pushed the get_current_segment_view branch from c9d082f to 66ea788 Compare December 18, 2024 07:51
@xiaocai2333 xiaocai2333 force-pushed the get_current_segment_view branch from 66ea788 to c396228 Compare December 18, 2024 08:02
@czs007
Copy link
Collaborator

czs007 commented Dec 18, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Dec 18, 2024
@sre-ci-robot sre-ci-robot merged commit a348122 into milvus-io:master Dec 18, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liliu-z liliu-z liliu-z left review comments

@bigsheeper bigsheeper bigsheeper left review comments

@congqixia congqixia Awaiting requested review from congqixia

@sunby sunby Awaiting requested review from sunby

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
6 participants
@xiaocai2333 @czs007 @sre-ci-robot @bigsheeper @liliu-z @yanliang567