Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix wrong size of arrow array for zero-copy mode #38449

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Dec 13, 2024

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 13, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 13, 2024
@zhagnlu zhagnlu changed the title fix: fix wrong length of arrow array for zero-copy mode fix: fix wrong size of arrow array for zero-copy mode Dec 13, 2024
Copy link
Contributor

mergify bot commented Dec 13, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 13, 2024

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 13, 2024

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.93%. Comparing base (b416ff8) to head (1208a58).
Report is 6 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (b416ff8) and HEAD (1208a58). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (b416ff8) HEAD (1208a58)
5 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38449       +/-   ##
===========================================
- Coverage   80.86%   68.93%   -11.94%     
===========================================
  Files        1373      292     -1081     
  Lines      193020    26161   -166859     
===========================================
- Hits       156086    18034   -138052     
+ Misses      31407     8127    -23280     
+ Partials     5527        0     -5527     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 68.93% <ø> (ø)
Go ∅ <ø> (∅)

see 1081 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Dec 13, 2024

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Dec 15, 2024

rerun go-sdk

@mergify mergify bot added the ci-passed label Dec 15, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 15, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c3edc85 into milvus-io:master Dec 15, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants