Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: return exception type name when segcore return unkonwn exception #38326

Merged
merged 1 commit into from
Dec 25, 2024
Merged

enhance: return exception type name when segcore return unkonwn exception #38326

merged 1 commit into from
Dec 25, 2024

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Dec 10, 2024

relate: #38265

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 10, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 10, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.04%. Comparing base (bb5f38e) to head (2b887ef).
Report is 20 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38326      +/-   ##
==========================================
+ Coverage   81.02%   81.04%   +0.01%     
==========================================
  Files        1380     1380              
  Lines      195145   195150       +5     
==========================================
+ Hits       158115   158153      +38     
+ Misses      31448    31426      -22     
+ Partials     5582     5571      -11
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.33% <100.00%> (ø)
Go 83.02% <ø> (+0.01%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/futures/Future.h 98.33% <100.00%> (ø)

... and 21 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 10, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 13, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Dec 16, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 16, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Dec 16, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 16, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@aoiasd aoiasd force-pushed the C7 branch 2 times, most recently from 0a0b1cd to d466281 Compare December 17, 2024 11:21
@sre-ci-robot sre-ci-robot added area/compilation area/dependency Pull requests that update a dependency file area/internal-api area/test sig/testing test/integration integration test and removed size/S Denotes a PR that changes 10-29 lines. labels Dec 17, 2024
@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Dec 17, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 17, 2024

@aoiasd Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Dec 17, 2024
@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. and removed size/XXL Denotes a PR that changes 1000+ lines. labels Dec 18, 2024
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Dec 18, 2024
@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Dec 18, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 18, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 19, 2024

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 19, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 23, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 23, 2024

@aoiasd cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Dec 24, 2024

rerun cpp-unit-test

@mergify mergify bot added the ci-passed label Dec 24, 2024
congqixia
congqixia approved these changes Dec 25, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c7ea09a into milvus-io:master Dec 25, 2024
20 checks passed
congqixia
congqixia reviewed Dec 25, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: update the error message and pre-check this expression in proxy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

@xiaofan-luan xiaofan-luan

@congqixia congqixia

Labels
approved area/compilation area/dependency Pull requests that update a dependency file area/internal-api area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/S Denotes a PR that changes 10-29 lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aoiasd @xiaofan-luan @sre-ci-robot @congqixia