Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Empty access log #38293

Open
1 task
DTF123 opened this issue Dec 8, 2024 · 6 comments
Open
1 task

[Bug]: Empty access log #38293

DTF123 opened this issue Dec 8, 2024 · 6 comments
Assignees
@aoiasd
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
2.4.19

Comments

@DTF123
Copy link

DTF123 commented Dec 8, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version:4.17.0
- Deployment mode(standalone or cluster):standalone
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): CentOS
- CPU/Memory: 16G 4Core
- GPU: 
- Others:

Current Behavior

After configuring the access log according to the documentation, there are logs within the container, but it is empty.
mmexport1733657045514
Add log config like this
17ebd764-54db-4f85-9f0e-fc3590d0f5bf

Expected Behavior

No response

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@DTF123 DTF123 added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 8, 2024
@xiaofan-luan
Copy link
Collaborator

I guess the rotate time should not be 7 seconds but 7days.

@yanliang567
Copy link
Contributor

/assign @aoiasd
please help to take a look. there are always 5(not all) empty files when i try to reproduce the issue.
image

/unassign

@sre-ci-robot sre-ci-robot assigned aoiasd and unassigned yanliang567 Dec 9, 2024
@yanliang567 yanliang567 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 9, 2024
@yanliang567 yanliang567 added this to the 2.4.18 milestone Dec 9, 2024
@aoiasd
Copy link
Contributor

aoiasd commented Dec 9, 2024

Rotate time units was second, not hours. So we rotate files every 24 seconds in this case.

@aoiasd
Copy link
Contributor

aoiasd commented Dec 9, 2024

Maybe we should skip rotate when file was empty，i will do this.

@aoiasd
Copy link
Contributor

aoiasd commented Dec 9, 2024

Find other bugs, access log remove old files when files number large than maxBackups, but file list was unordered, case may remove the new file, not the old filed. Will fix together.

@aoiasd aoiasd mentioned this issue Dec 9, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Dec 17, 2024
@aoiasd
fix: access log remove new log not the old and skip rotate empty log (#…
93fba1d 
…38309)

relate: #38293

Signed-off-by: aoiasd <[email protected]>
aoiasd added a commit to aoiasd/milvus that referenced this issue Dec 17, 2024
@aoiasd
fix: access log remove new log not the old and skip rotate empty log (m…
d466281 
…ilvus-io#38309)

relate: milvus-io#38293

Signed-off-by: aoiasd <[email protected]>
This was referenced Dec 17, 2024
Closed
Merged
aoiasd added a commit to aoiasd/milvus that referenced this issue Dec 23, 2024
@aoiasd
fix: access log remove new log not the old and skip rotate empty log (m…
a42a517 
…ilvus-io#38309)

relate: milvus-io#38293

Signed-off-by: aoiasd <[email protected]>
@yanliang567 yanliang567 modified the milestones: 2.4.18, 2.4.19 Dec 24, 2024
sre-ci-robot pushed a commit that referenced this issue Dec 25, 2024
@aoiasd
fix: [Cherry-pick] access log retention new log not the old and skip …
b9eb396 
…rotate empty log (#38661)

pr: #38309
relate: #38293

Signed-off-by: aoiasd <[email protected]>
@nelevg
Copy link

nelevg commented Dec 25, 2024

We have the same problem on 2.4.6 cluster depl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aoiasd aoiasd

Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
2.4.19
Development

No branches or pull requests
5 participants
@aoiasd @yanliang567 @xiaofan-luan @nelevg @DTF123