Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix init rootcoord meta timeout #38248

Merged
merged 2 commits into from
Dec 8, 2024
Merged

fix: Fix init rootcoord meta timeout #38248

merged 2 commits into from
Dec 8, 2024

Conversation

bigsheeper
Copy link
Contributor

issue: #37630

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 5, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 5, 2024
@bigsheeper bigsheeper mentioned this pull request Dec 5, 2024
Merged
czs007 pushed a commit that referenced this pull request Dec 5, 2024
@bigsheeper
fix: [10kcp] Fix init rootcoord meta timeout (#38249)
df100e5 
issue: #37630

pr: #38248

Signed-off-by: bigsheeper <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 5, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 5, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Dec 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.97%. Comparing base (6ff1948) to head (08411cf).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
internal/metastore/kv/rootcoord/suffix_snapshot.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38248      +/-   ##
==========================================
+ Coverage   81.07%   82.97%   +1.90%     
==========================================
  Files        1372     1083     -289     
  Lines      191491   165985   -25506     
==========================================
- Hits       155243   137723   -17520     
+ Misses      30752    22774    -7978     
+ Partials     5496     5488       -8
Components Coverage Δ
Client 74.43% <ø> (ø)
Core ∅ <ø> (∅)
Go 83.21% <77.77%> (+0.02%) ⬆️
Files with missing lines Coverage Δ
internal/metastore/kv/rootcoord/kv_catalog.go 80.69% <ø> (ø)
internal/metastore/kv/rootcoord/suffix_snapshot.go 81.05% <77.77%> (-0.14%) ⬇️

... and 320 files with indirect coverage changes

bigsheeper added a commit to bigsheeper/milvus that referenced this pull request Dec 5, 2024
@bigsheeper
fix: [10kcp] Fix init rootcoord meta timeout (milvus-io#38249)
69c7492 
issue: milvus-io#37630

pr: milvus-io#38248

Signed-off-by: bigsheeper <[email protected]>
@bigsheeper bigsheeper mentioned this pull request Dec 5, 2024
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 5, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Dec 6, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 8, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 7a5aea1 into milvus-io:master Dec 8, 2024
19 of 20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Dec 8, 2024
@bigsheeper
fix: [2.4] Fix init rootcoord meta timeout (#38249) (#38253)
bd1ffea 
issue: #37630

pr: #38248

Signed-off-by: bigsheeper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xige-16 xige-16 Awaiting requested review from xige-16

@zwd1208 zwd1208 Awaiting requested review from zwd1208

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bigsheeper @czs007 @sre-ci-robot