Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid rate limit for time tick delay #38218

Merged

Conversation

jaime0815
Copy link
Contributor

issue: #38217

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 4, 2024
@sre-ci-robot sre-ci-robot requested review from cydrain and sunby December 4, 2024 12:46
@mergify mergify bot added the dco-passed DCO check passed. label Dec 4, 2024
Copy link
Contributor

mergify bot commented Dec 4, 2024

@jaime0815 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.61%. Comparing base (febed0a) to head (8b7f25e).
Report is 3 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38218      +/-   ##
==========================================
+ Coverage   70.40%   79.61%   +9.21%     
==========================================
  Files        1074     1074              
  Lines      168099   168106       +7     
==========================================
+ Hits       118353   133845   +15492     
+ Misses      45291    29816   -15475     
+ Partials     4455     4445      -10     
Files with missing lines Coverage Δ
internal/datanode/flow_graph_write_node.go 85.05% <100.00%> (+0.17%) ⬆️

... and 254 files with indirect coverage changes

@bigsheeper
Copy link
Contributor

Maybe querynode pipeline needs to update tt too.

@bigsheeper
Copy link
Contributor

/lgtm

@czs007
Copy link
Collaborator

czs007 commented Dec 5, 2024

/approve
/lgtm

@czs007 czs007 added the manual-pass manually set pass before ci-passed labeled label Dec 5, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 5, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 67a004c into milvus-io:2.4 Dec 5, 2024
15 checks passed
@jaime0815 jaime0815 deleted the fix-invalid-tt-dealy-ratelimit branch December 5, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/branch-feature kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants