Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Fill version for load delta request #38212

Merged

Conversation

congqixia
Copy link
Contributor

Version is needed for load delta request in case of false alarm warning about version go backward

Version is needed for load delta request in case of false alarm warning
about version go backward

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 4, 2024
@sre-ci-robot sre-ci-robot requested review from aoiasd and yah01 December 4, 2024 11:11
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.12%. Comparing base (a65d395) to head (c9e398f).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
internal/querynodev2/delegator/delta_forward.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38212      +/-   ##
==========================================
+ Coverage   81.07%   81.12%   +0.04%     
==========================================
  Files        1372     1372              
  Lines      191479   191539      +60     
==========================================
+ Hits       155251   155378     +127     
+ Misses      30727    30676      -51     
+ Partials     5501     5485      -16     
Components Coverage Δ
Client 74.43% <ø> (ø)
Core 68.88% <ø> (ø)
Go 83.24% <0.00%> (+0.05%) ⬆️
Files with missing lines Coverage Δ
internal/querynodev2/delegator/delta_forward.go 70.80% <0.00%> (-0.24%) ⬇️

... and 36 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 5, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 3c6a373 into milvus-io:master Dec 5, 2024
19 of 20 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Dec 5, 2024
Version is needed for load delta request in case of false alarm warning
about version go backward

Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Dec 5, 2024
Cherry-pick from master
pr: #38212
Version is needed for load delta request in case of false alarm warning
about version go backward

Signed-off-by: Congqi Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants