Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: grant ManualCompact api doesn't work (#38096) #38168

Merged
merged 1 commit into from
Dec 5, 2024
Merged

fix: grant ManualCompact api doesn't work (#38096) #38168

merged 1 commit into from
Dec 5, 2024

Conversation

weiliu1031
Copy link
Contributor

@weiliu1031 weiliu1031 commented Dec 3, 2024 •
edited
Loading

issue: #38086
pr: #38096
cause ManualCompact api pass collection id in request, but RBAC requires to check collection name, so grant ManualCompact api doesn't work.

This PR refine the ManualCompact api to accpet collection name in request.

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. area/dependency Pull requests that update a dependency file labels Dec 3, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Dec 3, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 3, 2024

@weiliu1031 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 3, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 3, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031 weiliu1031 force-pushed the fix_manual_compact24 branch from 2450976 to 283ea7d Compare December 3, 2024 11:38
@codecov Codecov
Copy link

codecov bot commented Dec 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.

Project coverage is 72.23%. Comparing base (dca779d) to head (423dbd8).
Report is 17 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/proxy/impl.go 12.50% 6 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.4   #38168       +/-   ##
===========================================
- Coverage   83.58%   72.23%   -11.36%     
===========================================
  Files         805     1074      +269     
  Lines      141188   168106    +26918     
===========================================
+ Hits       118018   121432     +3414     
- Misses      18724    42224    +23500     
- Partials     4446     4450        +4
Files with missing lines Coverage Δ
internal/proxy/database_interceptor.go 96.16% <100.00%> (+0.07%) ⬆️
internal/proxy/impl.go 84.91% <12.50%> (+0.11%) ⬆️

... and 336 files with indirect coverage changes

@weiliu1031
fix: grant ManualCompact api doesn't work (milvus-io#38096)
423dbd8 
issue: milvus-io#38086
cause ManualCompact api pass collection id in request, but RBAC requires
to check collection name, so grant ManualCompact api doesn't work.

This PR refine the ManualCompact api to accpet collection name in
request.

Signed-off-by: Wei Liu <[email protected]>
@weiliu1031 weiliu1031 force-pushed the fix_manual_compact24 branch from 283ea7d to 423dbd8 Compare December 4, 2024 08:42
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 4, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Dec 5, 2024
XuanYang-cn
XuanYang-cn approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

congqixia
congqixia approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 8646bba into milvus-io:2.4 Dec 5, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@XuanYang-cn XuanYang-cn XuanYang-cn approved these changes

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

@XuanYang-cn XuanYang-cn

Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weiliu1031 @sre-ci-robot @XuanYang-cn @congqixia