Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: support templates for expression in Restful api(#38040) #38161

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

smellthemoon
Copy link
Contributor

pr: #38040
issue: #36672

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 3, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 87.17949% with 20 lines in your changes missing coverage. Please review.

Project coverage is 70.43%. Comparing base (dca779d) to head (adefe1c).
Report is 15 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/distributed/proxy/httpserver/utils.go 86.57% 19 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.4   #38161       +/-   ##
===========================================
- Coverage   83.58%   70.43%   -13.16%     
===========================================
  Files         805     1073      +268     
  Lines      141188   167806    +26618     
===========================================
+ Hits       118018   118199      +181     
- Misses      18724    45172    +26448     
+ Partials     4446     4435       -11     
Files with missing lines Coverage Δ
...nternal/distributed/proxy/httpserver/handler_v2.go 91.98% <100.00%> (+0.01%) ⬆️
...nternal/distributed/proxy/httpserver/request_v2.go 97.33% <ø> (ø)
internal/distributed/proxy/httpserver/utils.go 85.99% <86.57%> (+0.07%) ⬆️

... and 300 files with indirect coverage changes

@czs007 czs007 added this to the 2.4.18 milestone Dec 4, 2024
@xiaocai2333
Copy link
Contributor

/lgtm

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, smellthemoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3d98e8e into milvus-io:2.4 Dec 5, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants