Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add ctx param to KV operation interfaces #38154

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

tinswzy
Copy link
Contributor

@tinswzy tinswzy commented Dec 2, 2024

issue: #35917
Refine KV operation interfaces by adding a ctx param

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Dec 2, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 2, 2024
Copy link
Contributor

mergify bot commented Dec 2, 2024

@tinswzy go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 2, 2024

@tinswzy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 94.00480% with 25 lines in your changes missing coverage. Please review.

Project coverage is 81.08%. Comparing base (e359725) to head (423765a).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
internal/kv/etcd/etcd_kv.go 88.67% 6 Missing ⚠️
internal/kv/etcd/embed_etcd_kv.go 92.85% 4 Missing ⚠️
internal/metastore/kv/rootcoord/kv_catalog.go 95.18% 3 Missing and 1 partial ⚠️
internal/kv/mem/mem_kv.go 86.36% 3 Missing ⚠️
internal/metastore/kv/rootcoord/suffix_snapshot.go 92.85% 3 Missing ⚠️
internal/metastore/kv/datacoord/kv_catalog.go 96.92% 2 Missing ⚠️
internal/datacoord/channel_store.go 66.66% 1 Missing ⚠️
internal/metastore/kv/querycoord/kv_catalog.go 95.00% 1 Missing ⚠️
pkg/mq/mqimpl/rocksmq/server/rocksmq_impl.go 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38154      +/-   ##
==========================================
- Coverage   81.11%   81.08%   -0.03%     
==========================================
  Files        1372     1372              
  Lines      191350   191480     +130     
==========================================
+ Hits       155219   155270      +51     
- Misses      30646    30710      +64     
- Partials     5485     5500      +15     
Components Coverage Δ
Client 74.43% <ø> (ø)
Core 68.88% <ø> (+<0.01%) ⬆️
Go 83.21% <94.00%> (-0.04%) ⬇️
Files with missing lines Coverage Δ
internal/datacoord/server.go 73.79% <100.00%> (+0.80%) ⬆️
internal/kv/tikv/txn_tikv.go 83.24% <100.00%> (ø)
internal/metastore/kv/streamingcoord/kv_catalog.go 81.25% <100.00%> (ø)
internal/metastore/kv/streamingnode/kv_catalog.go 76.00% <100.00%> (ø)
internal/querycoordv2/meta/resource_manager.go 82.07% <100.00%> (+0.02%) ⬆️
internal/querycoordv2/server.go 79.53% <100.00%> (ø)
internal/tso/tso.go 81.25% <100.00%> (ø)
pkg/kv/kv.go 0.00% <ø> (ø)
pkg/kv/rocksdb/rocksdb_kv.go 80.11% <100.00%> (ø)
pkg/mq/mqimpl/rocksmq/server/rocksmq_retention.go 76.72% <100.00%> (ø)
... and 9 more

... and 45 files with indirect coverage changes

@tinswzy
Copy link
Contributor Author

tinswzy commented Dec 2, 2024

rerun go-sdk

@tinswzy
Copy link
Contributor Author

tinswzy commented Dec 2, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Dec 2, 2024

@tinswzy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 2, 2024

@tinswzy go-sdk check failed, comment rerun go-sdk can trigger the job again.

@tinswzy
Copy link
Contributor Author

tinswzy commented Dec 3, 2024

rerun ut

@tinswzy
Copy link
Contributor Author

tinswzy commented Dec 3, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Dec 3, 2024

@tinswzy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tinswzy tinswzy force-pushed the refine_kv_ops_apis branch from c30d9c7 to 522a7bf Compare December 3, 2024 12:52
Copy link
Contributor

mergify bot commented Dec 3, 2024

@tinswzy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 3, 2024

@tinswzy go-sdk check failed, comment rerun go-sdk can trigger the job again.

@tinswzy tinswzy force-pushed the refine_kv_ops_apis branch from 522a7bf to cf0456f Compare December 3, 2024 13:08
Copy link
Contributor

mergify bot commented Dec 3, 2024

@tinswzy go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 3, 2024

@tinswzy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tinswzy tinswzy force-pushed the refine_kv_ops_apis branch from cf0456f to 868a9fd Compare December 3, 2024 14:37
Copy link
Contributor

mergify bot commented Dec 3, 2024

@tinswzy go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 3, 2024

@tinswzy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tinswzy tinswzy force-pushed the refine_kv_ops_apis branch from 868a9fd to b0042e9 Compare December 4, 2024 00:26
Copy link
Contributor

mergify bot commented Dec 4, 2024

@tinswzy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 4, 2024

@tinswzy go-sdk check failed, comment rerun go-sdk can trigger the job again.

@tinswzy tinswzy force-pushed the refine_kv_ops_apis branch from b0042e9 to 751cc84 Compare December 4, 2024 01:39
Copy link
Contributor

mergify bot commented Dec 4, 2024

@tinswzy go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 4, 2024

@tinswzy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tinswzy tinswzy force-pushed the refine_kv_ops_apis branch 2 times, most recently from adde23b to 0c861ca Compare December 4, 2024 07:58
Copy link
Contributor

mergify bot commented Dec 4, 2024

@tinswzy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tinswzy tinswzy force-pushed the refine_kv_ops_apis branch from 0c861ca to 423765a Compare December 4, 2024 09:53
Copy link
Contributor

mergify bot commented Dec 4, 2024

@tinswzy go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 4, 2024

@tinswzy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tinswzy
Copy link
Contributor Author

tinswzy commented Dec 4, 2024

/run-cpu-e2e

@tinswzy
Copy link
Contributor Author

tinswzy commented Dec 4, 2024

rerun go-sdk

Copy link
Contributor

mergify bot commented Dec 4, 2024

@tinswzy go-sdk check failed, comment rerun go-sdk can trigger the job again.

@tinswzy
Copy link
Contributor Author

tinswzy commented Dec 4, 2024

rerun go-sdk

@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: tinswzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 7944538 into milvus-io:master Dec 5, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants