-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: simplify segment interface by removing chunk_view method #38117
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tedxu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tedxu Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
@tedxu E2e jenkins job failed, comment |
@tedxu cpp-unit-test check failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #38117 +/- ##
==========================================
+ Coverage 81.08% 82.92% +1.84%
==========================================
Files 1372 1083 -289
Lines 191444 166116 -25328
==========================================
- Hits 155225 137751 -17474
+ Misses 30715 22851 -7864
- Partials 5504 5514 +10
|
@tedxu E2e jenkins job failed, comment |
1 similar comment
@tedxu E2e jenkins job failed, comment |
@tedxu go-sdk check failed, comment |
@tedxu cpp-unit-test check failed, comment |
Signed-off-by: Ted Xu <[email protected]>
Signed-off-by: Ted Xu <[email protected]>
55ae720
to
c12738b
Compare
@tedxu cpp-unit-test check failed, comment |
@tedxu E2e jenkins job failed, comment |
Signed-off-by: Ted Xu <[email protected]>
See #38118