Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: simplify segment interface by removing chunk_view method #38117

Closed

Conversation

tedxu
Copy link
Contributor

@tedxu tedxu commented Nov 30, 2024

See #38118

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tedxu
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 30, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 30, 2024
Copy link
Contributor

mergify bot commented Nov 30, 2024

@tedxu Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Nov 30, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 30, 2024

@tedxu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.92%. Comparing base (8636392) to head (c12738b).
Report is 122 commits behind head on master.

Current head c12738b differs from pull request most recent head 836aa81

Please upload reports for the commit 836aa81 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38117      +/-   ##
==========================================
+ Coverage   81.08%   82.92%   +1.84%     
==========================================
  Files        1372     1083     -289     
  Lines      191444   166116   -25328     
==========================================
- Hits       155225   137751   -17474     
+ Misses      30715    22851    -7864     
- Partials     5504     5514      +10     
Components Coverage Δ
Client 74.58% <ø> (+0.14%) ⬆️
Core ∅ <ø> (∅)
Go 83.16% <ø> (-0.04%) ⬇️

see 386 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Dec 1, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented Dec 6, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 6, 2024

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 6, 2024

@tedxu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@tedxu tedxu force-pushed the enhance/simpilfy_segment_interface branch from 55ae720 to c12738b Compare December 6, 2024 10:27
Copy link
Contributor

mergify bot commented Dec 6, 2024

@tedxu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 6, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: Ted Xu <[email protected]>
@tedxu tedxu closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants