Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: report restful info to hook #38112

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Nov 29, 2024

No description provided.

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 29, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 29, 2024
Copy link
Contributor

mergify bot commented Nov 29, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 29, 2024

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 40.74074% with 16 lines in your changes missing coverage. Please review.

Project coverage is 81.09%. Comparing base (34d7128) to head (4831db7).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/authentication_interceptor.go 0.00% 16 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38112       +/-   ##
===========================================
+ Coverage   68.88%   81.09%   +12.21%     
===========================================
  Files         289     1372     +1083     
  Lines       25496   191590   +166094     
===========================================
+ Hits        17563   155374   +137811     
- Misses       7933    30726    +22793     
- Partials        0     5490     +5490     
Components Coverage Δ
Client 74.43% <ø> (∅)
Core 68.85% <ø> (-0.04%) ⬇️
Go 83.22% <40.74%> (∅)
Files with missing lines Coverage Δ
...nternal/distributed/proxy/httpserver/handler_v2.go 92.58% <100.00%> (ø)
internal/distributed/proxy/httpserver/utils.go 84.52% <100.00%> (ø)
internal/distributed/proxy/service.go 85.47% <100.00%> (ø)
internal/proxy/authentication_interceptor.go 76.25% <0.00%> (ø)

... and 1081 files with indirect coverage changes

@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Dec 2, 2024
@aoiasd aoiasd force-pushed the AduitLog branch 2 times, most recently from 54c0e59 to 793d167 Compare December 3, 2024 06:56
Copy link
Contributor

mergify bot commented Dec 3, 2024

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Dec 3, 2024

rerun go-sdk

1 similar comment
@aoiasd
Copy link
Contributor Author

aoiasd commented Dec 3, 2024

rerun go-sdk

Copy link
Contributor

mergify bot commented Dec 4, 2024

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

Signed-off-by: aoiasd <[email protected]>
Copy link
Contributor

mergify bot commented Dec 5, 2024

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Dec 5, 2024

rerun go-sdk

@mergify mergify bot added the ci-passed label Dec 5, 2024
@SimFG
Copy link
Contributor

SimFG commented Dec 5, 2024

/lgtm

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c91bb5a into milvus-io:master Dec 5, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/M Denotes a PR that changes 30-99 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants