Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Remove unnecessary segment validation on worker node #38108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

weiliu1031
Copy link
Contributor

@weiliu1031 weiliu1031 commented Nov 29, 2024

issue: #38109
This PR remove unnecessary segment validation on worker node, also refine the segment's func call on pin and unpin.

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 29, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 29, 2024
Copy link
Contributor

mergify bot commented Nov 29, 2024

@weiliu1031 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Nov 29, 2024

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 75.34247% with 18 lines in your changes missing coverage. Please review.

Project coverage is 80.90%. Comparing base (833c74a) to head (25260fe).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/querynodev2/segments/search.go 75.67% 8 Missing and 1 partial ⚠️
internal/querynodev2/segments/statistics.go 45.45% 6 Missing ⚠️
internal/querynodev2/segments/retrieve.go 81.81% 2 Missing ⚠️
internal/querynodev2/handlers.go 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38108      +/-   ##
==========================================
+ Coverage   78.77%   80.90%   +2.13%     
==========================================
  Files        1365     1372       +7     
  Lines      191753   192965    +1212     
==========================================
+ Hits       151058   156123    +5065     
+ Misses      35198    31335    -3863     
- Partials     5497     5507      +10     
Components Coverage Δ
Client 74.58% <ø> (ø)
Core 68.91% <ø> (ø)
Go 83.02% <75.34%> (+2.53%) ⬆️
Files with missing lines Coverage Δ
internal/querynodev2/tasks/query_stream_task.go 78.72% <100.00%> (-0.45%) ⬇️
internal/querynodev2/tasks/query_task.go 90.09% <100.00%> (-0.09%) ⬇️
internal/querynodev2/tasks/search_task.go 84.49% <100.00%> (+1.37%) ⬆️
internal/querynodev2/handlers.go 77.07% <75.00%> (-0.12%) ⬇️
internal/querynodev2/segments/retrieve.go 82.53% <81.81%> (+0.13%) ⬆️
internal/querynodev2/segments/statistics.go 71.79% <45.45%> (-0.43%) ⬇️
internal/querynodev2/segments/search.go 65.95% <75.67%> (+8.47%) ⬆️

... and 249 files with indirect coverage changes

@weiliu1031 weiliu1031 force-pushed the remove_unnecessary_validation branch from 460373e to 5ffacaf Compare December 2, 2024 06:31
Copy link
Contributor

mergify bot commented Dec 2, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Dec 2, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031 weiliu1031 force-pushed the remove_unnecessary_validation branch from 5ffacaf to 6e1fdea Compare December 3, 2024 03:06
Copy link
Contributor

mergify bot commented Dec 3, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031 weiliu1031 force-pushed the remove_unnecessary_validation branch from 6e1fdea to 59e1d76 Compare December 3, 2024 11:06
Copy link
Contributor

mergify bot commented Dec 3, 2024

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Dec 4, 2024

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

This PR remove unnecessary segment validation on worker node, also
refine the segment's func call on `pin and unpin`.

Signed-off-by: Wei Liu <[email protected]>
@weiliu1031 weiliu1031 force-pushed the remove_unnecessary_validation branch from 59e1d76 to 25260fe Compare December 13, 2024 06:33
Copy link
Contributor

mergify bot commented Dec 13, 2024

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants