-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Remove unnecessary segment validation on worker node #38108
base: master
Are you sure you want to change the base?
enhance: Remove unnecessary segment validation on worker node #38108
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: weiliu1031 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@weiliu1031 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
@weiliu1031 go-sdk check failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #38108 +/- ##
==========================================
+ Coverage 78.77% 80.90% +2.13%
==========================================
Files 1365 1372 +7
Lines 191753 192965 +1212
==========================================
+ Hits 151058 156123 +5065
+ Misses 35198 31335 -3863
- Partials 5497 5507 +10
|
460373e
to
5ffacaf
Compare
@weiliu1031 E2e jenkins job failed, comment |
/run-cpu-e2e |
@weiliu1031 E2e jenkins job failed, comment |
5ffacaf
to
6e1fdea
Compare
@weiliu1031 E2e jenkins job failed, comment |
6e1fdea
to
59e1d76
Compare
@weiliu1031 go-sdk check failed, comment |
rerun go-sdk |
@weiliu1031 go-sdk check failed, comment |
This PR remove unnecessary segment validation on worker node, also refine the segment's func call on `pin and unpin`. Signed-off-by: Wei Liu <[email protected]>
59e1d76
to
25260fe
Compare
@weiliu1031 go-sdk check failed, comment |
issue: #38109
This PR remove unnecessary segment validation on worker node, also refine the segment's func call on
pin and unpin
.