enhance: no need database check in restful sdk

[smellthemoon]

#38077
remove the check for two reason

1. server will do the same to make sure use the correct database;
2. each req has an additional overhead of calling the proxy to check database.

[mergify]

@smellthemoon Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

[mergify]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.06%. Comparing base (23dc313) to head (a171b7d).
Report is 5 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #38078      +/-   ##
==========================================
- Coverage   81.06%   81.06%   -0.01%     
==========================================
  Files        1369     1369              
  Lines      190978   190957      -21     
==========================================
- Hits       154819   154801      -18     
- Misses      30659    30667       +8     
+ Partials     5500     5489      -11     

Components	Coverage Δ
Client	73.67% <ø> (ø)
Core	68.87% <ø> (ø)
Go	83.20% <100.00%> (-0.01%)	⬇️

Files with missing lines	Coverage Δ
...nternal/distributed/proxy/httpserver/handler_v2.go	92.52% <100.00%> (-0.08%)	⬇️
internal/rootcoord/drop_collection_task.go	100.00% <100.00%> (ø)
internal/rootcoord/meta_table.go	83.10% <100.00%> (+0.24%)	⬆️

... and 24 files with indirect coverage changes

[smellthemoon]

/run-cpu-e2e

[mergify]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

[czs007]

pytest : test] [gw5] [ 37%] FAILED testcases/test_vector_operations.py::TestInsertVectorNegative::test_insert_vector_with_invalid_database_name

[pytest : test]

[pytest : test] =================================== FAILURES ===================================

[pytest : test] ____ TestInsertVectorNegative.test_insert_vector_with_invalid_database_name ____

[pytest : test] [gw5] linux -- Python 3.10.12 /usr/local/bin/python3

[pytest : test] [gw5] linux -- Python 3.10.12 /usr/local/bin/python3[gw5] linux -- Python 3.10.12 /usr/local/bin/python3

[pytest : test]

[pytest : test] self = <test_vector_operations.TestInsertVectorNegative object at 0x7f3f03cd50c0>

[pytest : test]

[pytest : test] def test_insert_vector_with_invalid_database_name(self):

[pytest : test] """

[pytest : test] Insert a vector with an invalid database name

[pytest : test] """

[pytest : test] # create a collection

[pytest : test] name = gen_collection_name()

[pytest : test] dim = 128

[pytest : test] payload = {

[pytest : test] "collectionName": name,

[pytest : test] "dimension": dim,

[pytest : test] }

[pytest : test] rsp = self.collection_client.collection_create(payload)

[pytest : test] assert rsp['code'] == 0

[pytest : test] rsp = self.collection_client.collection_describe(name)

[pytest : test] assert rsp['code'] == 0

[pytest : test] # insert data

[pytest : test] nb = 10

[pytest : test] data = get_data_by_payload(payload, nb)

[pytest : test] payload = {

[pytest : test] "collectionName": name,

[pytest : test] "data": data,

[pytest : test] }

[pytest : test] body_size = sys.getsizeof(json.dumps(payload))

[pytest : test] logger.info(f"body size: {body_size / 1024 / 1024} MB")

[pytest : test] success = False

[pytest : test] rsp = self.vector_client.vector_insert(payload, db_name="invalid_database")

[pytest : test] > assert rsp['code'] == 800

[pytest : test] E assert 100 == 800

[pytest : test]

[pytest : test] testcases/test_vector_operations.py:829: AssertionError

[mergify]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

[mergify]

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

[mergify]

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

[mergify]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

[smellthemoon]

pytest : test] [gw5] [ 37%] FAILED testcases/test_vector_operations.py::TestInsertVectorNegative::test_insert_vector_with_invalid_database_name

[pytest : test]

[pytest : test] =================================== FAILURES ===================================

[pytest : test] ____ TestInsertVectorNegative.test_insert_vector_with_invalid_database_name ____

[pytest : test] [gw5] linux -- Python 3.10.12 /usr/local/bin/python3

[pytest : test] [gw5] linux -- Python 3.10.12 /usr/local/bin/python3[gw5] linux -- Python 3.10.12 /usr/local/bin/python3

[pytest : test]

[pytest : test] self = <test_vector_operations.TestInsertVectorNegative object at 0x7f3f03cd50c0>

[pytest : test]

[pytest : test] def test_insert_vector_with_invalid_database_name(self):

[pytest : test] """

[pytest : test] Insert a vector with an invalid database name

[pytest : test] """

[pytest : test] # create a collection

[pytest : test] name = gen_collection_name()

[pytest : test] dim = 128

[pytest : test] payload = {

[pytest : test] "collectionName": name,

[pytest : test] "dimension": dim,

[pytest : test] }

[pytest : test] rsp = self.collection_client.collection_create(payload)

[pytest : test] assert rsp['code'] == 0

[pytest : test] rsp = self.collection_client.collection_describe(name)

[pytest : test] assert rsp['code'] == 0

[pytest : test] # insert data

[pytest : test] nb = 10

[pytest : test] data = get_data_by_payload(payload, nb)

[pytest : test] payload = {

[pytest : test] "collectionName": name,

[pytest : test] "data": data,

[pytest : test] }

[pytest : test] body_size = sys.getsizeof(json.dumps(payload))

[pytest : test] logger.info(f"body size: {body_size / 1024 / 1024} MB")

[pytest : test] success = False

[pytest : test] rsp = self.vector_client.vector_insert(payload, db_name="invalid_database")

[pytest : test] > assert rsp['code'] == 800

[pytest : test] E assert 100 == 800

[pytest : test]

[pytest : test] testcases/test_vector_operations.py:829: AssertionError

because in rootcoord, first see whether the collection exist and then see the db exist, has already change it logic in rootcoord.

[smellthemoon]

@czs007 But I am not sure whether I should change the code or the test case here, because the errors reported here are actually correct. The root cause is that, under a non-existent db, restful would report an error of db not exist, but pymilvus would report an error of collection not found. Any comment about this?

[mergify]

@smellthemoon Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

[mergify]

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

[mergify]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

[smellthemoon]

/run-cpu-e2e

[smellthemoon]

rerun go-sdk

[mergify]

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

[mergify]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

[mergify]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

[mergify]

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

[mergify]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

[smellthemoon]

/run-cpu-e2e

[czs007]

/approve
/lgtm

[sre-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, smellthemoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• internal/distributed/OWNERS [czs007]
• internal/rootcoord/OWNERS [czs007]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment