Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: refactor delete mvcc function #38066

Merged
merged 1 commit into from
Dec 15, 2024
Merged

enhance: refactor delete mvcc function #38066

merged 1 commit into from
Dec 15, 2024

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Nov 28, 2024

@sre-ci-robot sre-ci-robot added area/compilation size/XL Denotes a PR that changes 500-999 lines. labels Nov 28, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 28, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 28, 2024

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 28, 2024

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 28, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu zhagnlu force-pushed the refactor_delete_framework branch from 9d2606d to f155e29 Compare November 28, 2024 03:50
@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Nov 28, 2024
@zhagnlu zhagnlu force-pushed the refactor_delete_framework branch from f155e29 to 7f80365 Compare November 28, 2024 04:09
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.13793% with 23 lines in your changes missing coverage. Please review.

Project coverage is 80.88%. Comparing base (10460ed) to head (0f7f4bb).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/segcore/DeletedRecord.h 87.39% 15 Missing ⚠️
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 40.00% 3 Missing ⚠️
...ternal/core/src/segcore/ChunkedSegmentSealedImpl.h 33.33% 2 Missing ⚠️
internal/core/src/segcore/SegmentGrowingImpl.h 66.66% 2 Missing ⚠️
internal/core/src/segcore/SegmentGrowingImpl.cpp 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38066      +/-   ##
==========================================
- Coverage   80.89%   80.88%   -0.01%     
==========================================
  Files        1373     1373              
  Lines      192959   192937      -22     
==========================================
- Hits       156092   156055      -37     
- Misses      31350    31352       +2     
- Partials     5517     5530      +13
Components Coverage Δ
Client 74.58% <ø> (ø)
Core 68.95% <84.13%> (+0.03%) ⬆️
Go 82.98% <ø> (-0.03%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/common/Utils.h 90.81% <ø> (ø)
internal/core/src/segcore/SegmentInterface.h 71.15% <ø> (ø)
internal/core/src/segcore/SegmentSealed.h 100.00% <ø> (ø)
internal/core/src/segcore/SegmentSealedImpl.cpp 84.42% <100.00%> (-1.68%) ⬇️
internal/core/src/segcore/SegmentSealedImpl.h 51.51% <100.00%> (+6.68%) ⬆️
internal/core/src/segcore/Utils.h 100.00% <ø> (ø)
internal/core/src/segcore/SegmentGrowingImpl.cpp 80.69% <66.66%> (+3.31%) ⬆️
...ternal/core/src/segcore/ChunkedSegmentSealedImpl.h 28.57% <33.33%> (+10.92%) ⬆️
internal/core/src/segcore/SegmentGrowingImpl.h 69.04% <66.66%> (-0.96%) ⬇️
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 22.89% <40.00%> (+0.71%) ⬆️
... and 1 more

... and 32 files with indirect coverage changes

@zhagnlu zhagnlu force-pushed the refactor_delete_framework branch from 7f80365 to beeccfe Compare November 28, 2024 07:33
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 28, 2024

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@zhagnlu zhagnlu force-pushed the refactor_delete_framework branch 2 times, most recently from 70f6fb9 to 44f06dd Compare November 28, 2024 10:15
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 28, 2024

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 28, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu zhagnlu force-pushed the refactor_delete_framework branch 2 times, most recently from 4f7f81b to 9632660 Compare November 29, 2024 08:26
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 29, 2024

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 29, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Nov 29, 2024

rerun cpp-unit-test

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Nov 29, 2024

/run-cpu-e2

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Dec 2, 2024

rerun cpp-unit-test

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Dec 2, 2024

/run-cpu-e2

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Dec 2, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 2, 2024

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 2, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu zhagnlu force-pushed the refactor_delete_framework branch from 541e449 to 1c21ee8 Compare December 3, 2024 07:40
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 3, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Dec 3, 2024

/run-cpu-e2e

1 similar comment
@zhagnlu
Copy link
Contributor Author

zhagnlu commented Dec 3, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 3, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu zhagnlu force-pushed the refactor_delete_framework branch from 1c21ee8 to 01e39f3 Compare December 4, 2024 07:09
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 4, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Dec 4, 2024

/run-cpu-e2e

1 similar comment
@zhagnlu
Copy link
Contributor Author

zhagnlu commented Dec 4, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 4, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Dec 4, 2024

/run-cpu-e2e

2 similar comments
@zhagnlu
Copy link
Contributor Author

zhagnlu commented Dec 4, 2024

/run-cpu-e2e

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Dec 4, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 4, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Dec 4, 2024
@zhagnlu zhagnlu force-pushed the refactor_delete_framework branch from 01e39f3 to 7e4e156 Compare December 5, 2024 06:40
@mergify mergify bot removed the ci-passed label Dec 5, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 5, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu zhagnlu force-pushed the refactor_delete_framework branch from 7e4e156 to 0daa476 Compare December 9, 2024 08:40
@zhagnlu zhagnlu force-pushed the refactor_delete_framework branch from 0daa476 to 0f7f4bb Compare December 13, 2024 06:01
@mergify mergify bot added the ci-passed label Dec 13, 2024
@czs007 czs007 added this to the 2.5.0 milestone Dec 13, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 15, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 01de0af into milvus-io:master Dec 15, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godchen0212 godchen0212 Awaiting requested review from godchen0212

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

@czs007 czs007

Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@zhagnlu @czs007 @sre-ci-robot