-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [2.5] Check if the dynamic fields contain any static fields #38026
Conversation
Signed-off-by: Cai Zhang <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xiaocai2333 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
@xiaocai2333 E2e jenkins job failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.5 #38026 +/- ##
=======================================
Coverage 81.04% 81.04%
=======================================
Files 1360 1360
Lines 190664 190661 -3
=======================================
+ Hits 154518 154528 +10
+ Misses 30648 30645 -3
+ Partials 5498 5488 -10
|
/run-cpu-e2e |
@xiaocai2333 E2e jenkins job failed, comment |
/run-cpu-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@@ -1792,11 +1792,20 @@ func verifyDynamicFieldData(schema *schemapb.CollectionSchema, insertMsg *msgstr | |||
for _, rowData := range field.GetScalars().GetJsonData().GetData() { | |||
jsonData := make(map[string]interface{}) | |||
if err := json.Unmarshal(rowData, &jsonData); err != nil { | |||
return err | |||
log.Warn("insert invalid dynamic data, milvus only support json map", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incorrect user input should not cause a warn log? warn log is more like for internal system warns.
comment is not blocking, not requesting a change in this PR
close with #38025 |
@xiaocai2333: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
issue: #38024
master pr: #38025