Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] Check if the dynamic fields contain any static fields #38026

Closed

Conversation

xiaocai2333
Copy link
Contributor

issue: #38024

master pr: #38025

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiaocai2333
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 26, 2024
Copy link
Contributor

mergify bot commented Nov 26, 2024

@xiaocai2333

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@xiaocai2333 xiaocai2333 changed the title fix [2.5] Check if the dynamic fields contain any static fields fix: [2.5] Check if the dynamic fields contain any static fields Nov 26, 2024
@mergify mergify bot added kind/bug Issues or changes related a bug and removed do-not-merge/invalid-pr-format labels Nov 26, 2024
Copy link
Contributor

mergify bot commented Nov 26, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.04%. Comparing base (797db3d) to head (6edd8b1).
Report is 3 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.5   #38026   +/-   ##
=======================================
  Coverage   81.04%   81.04%           
=======================================
  Files        1360     1360           
  Lines      190664   190661    -3     
=======================================
+ Hits       154518   154528   +10     
+ Misses      30648    30645    -3     
+ Partials     5498     5488   -10     
Components Coverage Δ
Client 72.16% <ø> (ø)
Core 68.87% <ø> (ø)
Go 83.22% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/proxy/util.go 89.98% <100.00%> (+0.05%) ⬆️
internal/proxy/validate_util.go 89.20% <ø> (-0.17%) ⬇️

... and 27 files with indirect coverage changes

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 26, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@zhengbuqian zhengbuqian added this to the 2.5.0 milestone Nov 26, 2024
@mergify mergify bot added the ci-passed label Nov 26, 2024
Copy link
Collaborator

@zhengbuqian zhengbuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@@ -1792,11 +1792,20 @@ func verifyDynamicFieldData(schema *schemapb.CollectionSchema, insertMsg *msgstr
for _, rowData := range field.GetScalars().GetJsonData().GetData() {
jsonData := make(map[string]interface{})
if err := json.Unmarshal(rowData, &jsonData); err != nil {
return err
log.Warn("insert invalid dynamic data, milvus only support json map",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrect user input should not cause a warn log? warn log is more like for internal system warns.

comment is not blocking, not requesting a change in this PR

@xiaocai2333
Copy link
Contributor Author

close with #38025
/close

@sre-ci-robot
Copy link
Contributor

@xiaocai2333: Closed this PR.

In response to this:

close with #38025
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants