Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Mark cgo pool with thread name #37999

Open
1 task done
congqixia opened this issue Nov 25, 2024 · 1 comment
Open
1 task done

[Enhancement]: Mark cgo pool with thread name #37999

congqixia opened this issue Nov 25, 2024 · 1 comment
Assignees
@congqixia
Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days

Comments

@congqixia
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

Use system API to mark cgo thread to make it easier to distinguish extra unexpected threads

Why is this needed?

Thread number is crucial to Milvus performance, with customized thread name, it is convenient for developer to locate the "leaked" thread source

Anything else?

No response
@congqixia congqixia added the kind/enhancement Issues or changes related to enhancement label Nov 25, 2024
@congqixia congqixia self-assigned this Nov 25, 2024
congqixia added a commit to congqixia/milvus that referenced this issue Nov 25, 2024
@congqixia
enhance: Mark cgo thread wit tag name
5ee2f2d 
Related to milvus-io#37999

This PR add `SetThreadName` API for marking cgo thread and utilize it
when initializing cgo worker.

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue Nov 25, 2024
Merged
congqixia added a commit to congqixia/milvus that referenced this issue Nov 25, 2024
@congqixia
enhance: Mark cgo thread wit tag name
3f17b1f 
Related to milvus-io#37999

This PR add `SetThreadName` API for marking cgo thread and utilize it
when initializing cgo worker.

Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Nov 26, 2024
@congqixia
enhance: Mark cgo thread with tag name (#38000)
cb65423 
Related to #37999

This PR add `SetThreadName` API for marking cgo thread and utilize it
when initializing cgo worker.

---------

Signed-off-by: Congqi Xia <[email protected]>
congqixia added a commit to congqixia/milvus that referenced this issue Nov 26, 2024
@congqixia
enhance: Mark cgo thread with tag name (milvus-io#38000)
c99a368 
Related to milvus-io#37999

This PR add `SetThreadName` API for marking cgo thread and utilize it
when initializing cgo worker.

---------

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue Nov 26, 2024
Closed
JsDove pushed a commit to JsDove/milvus that referenced this issue Nov 26, 2024
@congqixia @JsDove
enhance: Mark cgo thread with tag name (milvus-io#38000)
7319941 
Related to milvus-io#37999

This PR add `SetThreadName` API for marking cgo thread and utilize it
when initializing cgo worker.

---------

Signed-off-by: Congqi Xia <[email protected]>
@stale Stale
Copy link

stale bot commented Dec 28, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@congqixia congqixia

Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@congqixia