Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: used wrong label for query received_nq metrics #37982

Open
1 task done
Reidddddd opened this issue Nov 25, 2024 · 3 comments
Open
1 task done

[Bug]: used wrong label for query received_nq metrics #37982

Reidddddd opened this issue Nov 25, 2024 · 3 comments
Assignees
@czs007
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@Reidddddd
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version:
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

A query request will be labeled with search label

Expected Behavior

should be labeled with query

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@Reidddddd Reidddddd added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 25, 2024
Reidddddd added a commit to Reidddddd/milvus that referenced this issue Nov 25, 2024
@Reidddddd
[Bug]: used wrong label for query received_nq metrics (milvus-io#37982)
9dfd270
Reidddddd added a commit to Reidddddd/milvus that referenced this issue Nov 25, 2024
@Reidddddd
[Bug]: used wrong label for query received_nq metrics (milvus-io#37982)
512425b 
Signed-off-by: Reid Chan <[email protected]>
Reidddddd added a commit to Reidddddd/milvus that referenced this issue Nov 25, 2024
@Reidddddd
fix: used wrong label for query received_nq metrics (milvus-io#37982)
08da79c 
Signed-off-by: Reid Chan <[email protected]>
Reidddddd added a commit to Reidddddd/milvus that referenced this issue Nov 25, 2024
@Reidddddd
fix: used wrong label for query received_nq metrics (milvus-io#37982)
58caa75 
issue: milvus-io#37982

Signed-off-by: Reid Chan <[email protected]>
Reidddddd added a commit to Reidddddd/milvus that referenced this issue Nov 25, 2024
@Reidddddd
fix: used wrong label for query received_nq metrics
2cc7427 
issue: milvus-io#37982

Signed-off-by: Reid Chan <[email protected]>
@yanliang567
Copy link
Contributor

/assign @czs007
/unassign

@sre-ci-robot sre-ci-robot assigned czs007 and unassigned yanliang567 Nov 25, 2024
@yanliang567 yanliang567 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 25, 2024
@Reidddddd Reidddddd mentioned this issue Dec 3, 2024
Merged
Reidddddd added a commit to Reidddddd/milvus that referenced this issue Dec 6, 2024
@Reidddddd
fix: used wrong label for query received_nq metrics
cf981f6 
issue: milvus-io#37982
pr:    milvus-io#37987

Signed-off-by: Reid Chan <[email protected]>
Reidddddd added a commit to Reidddddd/milvus that referenced this issue Dec 6, 2024
@Reidddddd
fix: used wrong label for query received_nq metrics
e25ecea 
issue: milvus-io#37982
pr:    milvus-io#37987

Signed-off-by: Reid Chan <[email protected]>
@stale Stale
Copy link

stale bot commented Dec 28, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Dec 28, 2024
@Reidddddd
Copy link
Contributor Author

still waiting for being merged, approved already

@stale stale bot removed the stale indicates no udpates for 30 days label Dec 30, 2024
sre-ci-robot pushed a commit that referenced this issue Dec 30, 2024
@Reidddddd
fix: used wrong label for query received_nq metrics (#37987)
dd81a13 
issue: #37982

Signed-off-by: Reid Chan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@czs007 czs007

Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Reidddddd @czs007 @yanliang567