enhance: Use pool to limit kafka cgo thread number #37744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to milvus-io#37665 Thread number went rocket high when there is lots of kafka consumers on datanode. Since the internal implementation is CGO, using which directly will make cgo thread leaked. This PR add a worker pool for kafka API utilzing CGO calls to limit thread number. Signed-off-by: Congqi Xia <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
|
@congqixia cpp-unit-test check failed, comment |
|
rerun cpp-unit-test |
1 similar comment
|
rerun cpp-unit-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #37744 +/- ##
===========================================
+ Coverage 68.91% 80.68% +11.77%
===========================================
Files 290 1357 +1067
Lines 25471 190741 +165270
===========================================
+ Hits 17553 153902 +136349
- Misses 7918 31407 +23489
- Partials 0 5432 +5432
|
|
/lgtm |
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Nov 18, 2024
Introduced by milvus-io#37744 Signed-off-by: Congqi Xia <[email protected]>
czs007
pushed a commit
that referenced
this pull request
Nov 18, 2024
Introduced by #37744 Signed-off-by: Congqi Xia <[email protected]>
jaime0815
added a commit
to jaime0815/milvus
that referenced
this pull request
Dec 5, 2024
…#37744)" This reverts commit 3743fc2 Signed-off-by: jaime <[email protected]>
|
In scenarios with many vchannels, the pool limit may cause requests to wait or timeout. |
jaime0815
added a commit
to jaime0815/milvus
that referenced
this pull request
Dec 6, 2024
Revert "fix: Move init kafka pool into once (milvus-io#37786)" Revert "enhance: Use pool to limit kafka cgo thread number (milvus-io#37744)" Signed-off-by: jaime <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Dec 6, 2024
issue: #38263 Revert "fix: Move init kafka pool into once (#37786)" Revert "enhance: Use pool to limit kafka cgo thread number (#37744)" Signed-off-by: jaime <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #37665
Thread number went rocket high when there is lots of kafka consumers on datanode. Since the internal implementation is CGO, using which directly will make cgo thread leaked.
This PR add a worker pool for kafka API utilzing CGO calls to limit thread number.