Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: config manager cache fails to store default value #37690

Closed
1 task done
congqixia opened this issue Nov 14, 2024 · 0 comments
Closed
1 task done

[Bug]: config manager cache fails to store default value #37690

congqixia opened this issue Nov 14, 2024 · 0 comments
Assignees
@congqixia
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@congqixia
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: master & v2.4.15
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

When a param item is not present in any config source, the default value shall be used. However the manager cache cannot store is since the value is not equal to original value (*empty string)
This may cause a huge performance downgrade if some param for search logic is not present in any config source.

Expected Behavior

Config cache shall work with default value param item

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@congqixia congqixia added kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Nov 14, 2024
@congqixia congqixia self-assigned this Nov 14, 2024
congqixia added a commit to congqixia/milvus that referenced this issue Nov 14, 2024
@congqixia
fix: Store default value if ErrKeyNotFound is returned
5637028 
Related to milvus-io#37690

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue Nov 14, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Nov 15, 2024
@congqixia
fix: Store default value if ErrKeyNotFound is returned (#37691)
5afcee6 
Related to #37690

Signed-off-by: Congqi Xia <[email protected]>
congqixia added a commit to congqixia/milvus that referenced this issue Nov 15, 2024
@congqixia
fix: Store default value if ErrKeyNotFound is returned (milvus-io#3…
cadaaf0 
…7691)

Related to milvus-io#37690

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue Nov 15, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Nov 15, 2024
@congqixia
fix: [2.4] Store default value if ErrKeyNotFound is returned (#37691)…
e222289 
… (#37705)

Cherry-pick from master
pr: #37691
Related to #37690

Signed-off-by: Congqi Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@congqixia congqixia

Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@congqixia