Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Balance channel may stuck at increasing replica number case #37640

Closed
1 task done
weiliu1031 opened this issue Nov 13, 2024 · 4 comments
Closed
1 task done

[Bug]: Balance channel may stuck at increasing replica number case #37640

weiliu1031 opened this issue Nov 13, 2024 · 4 comments
Assignees
@weiliu1031
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
2.4.16

Comments

@weiliu1031
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: 2.4 and mater
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

cause balance channel will wait until new delegator becomes serviceable, but new delegator need to sync target version then becomes serviceable, and sync target version need to be wait all replica load done. so if increasing replica number and balance channel happens at same time, logic dead lock occurs.

Expected Behavior

No response

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@weiliu1031 weiliu1031 added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 13, 2024
@weiliu1031
Copy link
Contributor Author

/assign

This was referenced Nov 13, 2024
Merged
Merged
sre-ci-robot pushed a commit that referenced this issue Nov 13, 2024
@weiliu1031
fix: Balance channel may stuck at increasing replica number case (#37642
28bcd85 
)

issue: #37640
pr: #37641
fix the pr #36549
cause balance channel will wait until new delegator becomes serviceable,
but new delegator need to sync target version then becomes serviceable,
and sync target version need to be wait all replica load done. so if
increasing replica number and balance channel happens at same time,
logic dead lock occurs.

Signed-off-by: Wei Liu <[email protected]>
@yanliang567 yanliang567 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 13, 2024
@yanliang567 yanliang567 added this to the 2.4.15 milestone Nov 13, 2024
@yanliang567
Copy link
Contributor

/unassign

sre-ci-robot pushed a commit that referenced this issue Nov 14, 2024
@weiliu1031
fix: Balance channel may stuck at increasing replica number case (#37641
1304b40 
)

issue: #37640
fix the pr #36549
cause balance channel will wait until new delegator becomes serviceable,
but new delegator need to sync target version then becomes serviceable,
and sync target version need to be wait all replica load done. so if
increasing replica number and balance channel happens at same time,
logic dead lock occurs.

Signed-off-by: Wei Liu <[email protected]>
@yanliang567 yanliang567 modified the milestones: 2.4.15, 2.4.16 Nov 14, 2024
@xiaofan-luan
Copy link
Collaborator

@weiliu1031
how do we reproduce and verify this?

@weiliu1031
Copy link
Contributor Author

@weiliu1031 how do we reproduce and verify this?

the integration test TestDynamicUpdateLoadConfigs_WithRGLackOfNode will verify the above case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weiliu1031 weiliu1031

Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
2.4.16
Development

No branches or pull requests
3 participants
@yanliang567 @xiaofan-luan @weiliu1031