Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use yaml.v2 as yaml parser #37423

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

foxspy
Copy link
Contributor

@foxspy foxspy commented Nov 4, 2024

issue: #34298
Viper uses yaml.v2 as the parser. This PR will adopt the parsing logic from Viper to handle YAML files, ensuring maximum consistency in parsing.

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 4, 2024
@foxspy
Copy link
Contributor Author

foxspy commented Nov 4, 2024

/hold
wait #37418 merged

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 47.22222% with 19 lines in your changes missing coverage. Please review.

Project coverage is 80.55%. Comparing base (bc9562f) to head (a9c78a5).
Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
pkg/config/config.go 43.33% 16 Missing and 1 partial ⚠️
pkg/config/file_source.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37423      +/-   ##
==========================================
- Coverage   82.50%   80.55%   -1.95%     
==========================================
  Files        1064     1354     +290     
  Lines      163530   188907   +25377     
==========================================
+ Hits       134917   152177   +17260     
- Misses      23268    31379    +8111     
- Partials     5345     5351       +6     
Components Coverage Δ
Client 60.27% <ø> (ø)
Core 68.13% <ø> (∅)
Go 83.21% <47.22%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
pkg/config/file_source.go 77.89% <66.66%> (+0.75%) ⬆️
pkg/config/config.go 68.65% <43.33%> (-11.35%) ⬇️

... and 313 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Nov 4, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy foxspy force-pushed the update_yaml_parser branch from 5cd3f4b to 33551f2 Compare November 4, 2024 15:05
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Nov 4, 2024
@foxspy
Copy link
Contributor Author

foxspy commented Nov 4, 2024

/unhold

Copy link
Contributor

mergify bot commented Nov 4, 2024

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 4, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Nov 5, 2024

rerun go-sdk

@foxspy
Copy link
Contributor Author

foxspy commented Nov 5, 2024

/run-cpu-e2e

@foxspy foxspy requested a review from congqixia November 5, 2024 06:29
@foxspy foxspy force-pushed the update_yaml_parser branch from 33551f2 to 84fbb77 Compare November 5, 2024 11:35
Signed-off-by: xianliang.li <[email protected]>
@foxspy foxspy force-pushed the update_yaml_parser branch from 84fbb77 to a9c78a5 Compare November 8, 2024 01:53
Copy link
Contributor

mergify bot commented Nov 8, 2024

@foxspy cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 8, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Nov 8, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 8, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Nov 11, 2024

/run-cpu-e2e

@czs007
Copy link
Collaborator

czs007 commented Nov 11, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Nov 11, 2024
@mergify mergify bot added ci-passed and removed ci-passed labels Nov 11, 2024
@sre-ci-robot sre-ci-robot merged commit 81141bd into milvus-io:master Nov 11, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants