Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Add cgo call metrics for load/write API #37405

Merged
merged 2 commits into from
Nov 7, 2024
Merged

enhance: Add cgo call metrics for load/write API #37405

merged 2 commits into from
Nov 7, 2024

Conversation

congqixia
Copy link
Contributor

Cgo API cost is not observerable since not metrics is related to them. This PR add metrics for some sync cgo call related to load & write

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested review from aoiasd and sunby November 4, 2024 06:25
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 4, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 4, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@congqixia cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun cpp-unit-test

@congqixia
Copy link
Contributor Author

rerun go-sdk

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun go-sdk

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@codecov Codecov
Copy link

codecov bot commented Nov 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.04%. Comparing base (b3de4b0) to head (f38980f).
Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37405      +/-   ##
==========================================
- Coverage   83.25%   81.04%   -2.22%     
==========================================
  Files        1015     1305     +290     
  Lines      157480   182901   +25421     
==========================================
+ Hits       131116   148238   +17122     
- Misses      21172    29464    +8292     
- Partials     5192     5199       +7
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.37% <ø> (∅)
Go 83.27% <100.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
internal/querynodev2/segments/load_index_info.go 29.23% <100.00%> (+4.02%) ⬆️
internal/querynodev2/segments/segment.go 66.52% <100.00%> (+1.04%) ⬆️
pkg/metrics/metrics.go 100.00% <ø> (ø)
pkg/metrics/querynode_metrics.go 100.00% <100.00%> (ø)

... and 321 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Nov 5, 2024
@congqixia
enhance: Add cgo call metrics for load/write API
fa4e54f 
Cgo API cost is not observerable since not metrics is related to them.
This PR add metrics for some sync cgo call related to load & write

Signed-off-by: Congqi Xia <[email protected]>
@congqixia
Fix metrics label
f38980f 
Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia force-pushed the enhance/add_metrics_cgo_call branch from f8e7b67 to f38980f Compare November 6, 2024 06:31
@mergify mergify bot removed the ci-passed label Nov 6, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

@congqixia cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun cpp-unit-test

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

@congqixia cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun cpp-unit-test

1 similar comment
@congqixia
Copy link
Contributor Author

rerun cpp-unit-test

@mergify mergify bot added the ci-passed label Nov 6, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit ee54a98 into milvus-io:master Nov 7, 2024
19 of 20 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Nov 13, 2024
@congqixia
enhance: Add cgo call metrics for load/write API (milvus-io#37405)
7933eba 
Cgo API cost is not observerable since not metrics is related to them.
This PR add metrics for some sync cgo call related to load & write

---------

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this pull request Nov 13, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Nov 13, 2024
@congqixia
enhance: [2.4] Add cgo call metrics for load/write API (#37405) (#37627)
d073f32 
Cherry-pick from master
pr: #37405

Cgo API cost is not observerable since not metrics is related to them.
This PR add metrics for some sync cgo call related to load & write

---------

Signed-off-by: Congqi Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiliu1031 weiliu1031 weiliu1031 left review comments

@aoiasd aoiasd Awaiting requested review from aoiasd

@sunby sunby Awaiting requested review from sunby

Assignees

@weiliu1031 weiliu1031

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congqixia @sre-ci-robot @weiliu1031