Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Refine error message for contains array #37383

Merged
merged 1 commit into from
Nov 7, 2024
Merged

enhance: Refine error message for contains array #37383

merged 1 commit into from
Nov 7, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #36221

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 2, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 2, 2024
@xiaocai2333 xiaocai2333 mentioned this pull request Nov 2, 2024
Closed
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 2, 2024

@xiaocai2333 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 2, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 2, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

rerun ut

@xiaocai2333
Copy link
Contributor Author

rerun cpp-unit-test

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@xiaocai2333
Copy link
Contributor Author

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 2, 2024

@xiaocai2333 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 2, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@xiaocai2333
Copy link
Contributor Author

rerun cpp-unit-test

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 2, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Nov 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.31%. Comparing base (8714774) to head (92d13d7).
Report is 10 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (8714774) and HEAD (92d13d7). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (8714774) HEAD (92d13d7)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37383       +/-   ##
===========================================
- Coverage   81.06%   67.31%   -13.76%     
===========================================
  Files        1305      290     -1015     
  Lines      183048    25377   -157671     
===========================================
- Hits       148387    17082   -131305     
+ Misses      29462     8295    -21167     
+ Partials     5199        0     -5199
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.31% <ø> (-0.07%) ⬇️
Go ∅ <ø> (∅)

see 1019 files with indirect coverage changes

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 2, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 2, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333 xiaocai2333 force-pushed the refine_parse_contains_error_message branch from 02e5cce to 16360fe Compare November 4, 2024 07:44
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@xiaocai2333
Copy link
Contributor Author

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@xiaocai2333 xiaocai2333 mentioned this pull request Nov 5, 2024
Merged
@xiaocai2333 xiaocai2333 changed the title enhance: Refine error message for contains enhance: Refine error message for contains array Nov 5, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333 xiaocai2333 force-pushed the refine_parse_contains_error_message branch from 16360fe to 92d13d7 Compare November 6, 2024 09:01
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

@xiaocai2333 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

rerun cpp-unit-test

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

@xiaocai2333 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

rerun cpp-unit-test

@czs007
Copy link
Collaborator

czs007 commented Nov 7, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot pushed a commit that referenced this pull request Nov 7, 2024
@xiaocai2333
enhance: [2.4] Refine error message for contains array (#37443)
4ae5337 
issue: #36221 

master pr: #37383

Signed-off-by: Cai Zhang <[email protected]>
@mergify mergify bot removed the ci-passed label Nov 7, 2024
@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Nov 7, 2024
@sre-ci-robot sre-ci-robot merged commit aed3b94 into milvus-io:master Nov 7, 2024
17 of 20 checks passed
@xiaocai2333 xiaocai2333 deleted the refine_parse_contains_error_message branch November 8, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@yanliang567 yanliang567 Awaiting requested review from yanliang567

Assignees

@czs007 czs007

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled sig/testing size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaocai2333 @czs007 @sre-ci-robot