Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: repeated error code in milvus and segcore #37359

Merged
merged 1 commit into from
Nov 5, 2024
Merged

fix: repeated error code in milvus and segcore #37359

merged 1 commit into from
Nov 5, 2024

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Nov 1, 2024

issue: #37357

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 1, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 1, 2024
@chyezh chyezh mentioned this pull request Nov 1, 2024
Closed
@chyezh chyezh force-pushed the fix_repeated_error_code branch from cbd9eff to 0739a53 Compare November 1, 2024 07:47
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 1, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Nov 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.98%. Comparing base (0fc6c63) to head (52397a1).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37359       +/-   ##
===========================================
+ Coverage   67.19%   80.98%   +13.79%     
===========================================
  Files         290     1305     +1015     
  Lines       25426   182885   +157459     
===========================================
+ Hits        17084   148118   +131034     
- Misses       8342    29564    +21222     
- Partials        0     5203     +5203
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.17% <ø> (-0.02%) ⬇️
Go 83.24% <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/common/EasyAssert.h 84.61% <ø> (ø)
pkg/util/merr/errors.go 92.18% <ø> (ø)

... and 1015 files with indirect coverage changes

@chyezh chyezh force-pushed the fix_repeated_error_code branch from 0739a53 to 014a603 Compare November 2, 2024 04:49
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 2, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 2, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 2, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 3, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 3, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 3, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 3, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 3, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 3, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 4, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 4, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 4, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 4, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 4, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 4, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh chyezh force-pushed the fix_repeated_error_code branch from 014a603 to 52397a1 Compare November 5, 2024 02:16
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 5, 2024

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented Nov 5, 2024

rerun go-sdk

@mergify mergify bot added the ci-passed label Nov 5, 2024
@smellthemoon
Copy link
Contributor

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chyezh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9a0e1c8 into milvus-io:master Nov 5, 2024
19 of 20 checks passed
@chyezh chyezh deleted the fix_repeated_error_code branch November 5, 2024 08:53
@chyezh chyezh mentioned this pull request Nov 5, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Nov 7, 2024
@chyezh
fix: repeated error code in milvus and segcore (#37449)
cea8c75 
issue: #37357
pr: #37359

Signed-off-by: chyezh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@smellthemoon smellthemoon

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chyezh @smellthemoon @sre-ci-robot @jaime0815