enhance: improve rootcoord task scheduling policy #37352

SimFG · 2024-11-01T04:32:11Z

issue: [Bug]: [benchmark][cluster] Occasionally insertion failure and raises error getSegmentID failed: SegmentIDAllocator failRemainRequest unexpected error #30301

mergify · 2024-11-01T04:38:40Z

@SimFG cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

mergify · 2024-11-01T04:41:02Z

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify · 2024-11-01T05:30:26Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

codecov · 2024-11-01T07:15:42Z

Codecov Report

Attention: Patch coverage is 94.35897% with 11 lines in your changes missing coverage. Please review.

Project coverage is 81.05%. Comparing base (b3de4b0) to head (b746aa3).
Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
internal/rootcoord/scheduler.go	85.00%	4 Missing and 2 partials ⚠️
internal/rootcoord/task.go	88.63%	4 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #37352      +/-   ##
==========================================
- Coverage   83.25%   81.05%   -2.21%     
==========================================
  Files        1015     1305     +290     
  Lines      157480   183044   +25564     
==========================================
+ Hits       131116   148362   +17246     
- Misses      21172    29477    +8305     
- Partials     5192     5205      +13

Components	Coverage Δ
Client	`∅ <ø> (∅)`
Core	`67.37% <ø> (∅)`
Go	`83.27% <94.35%> (-0.01%)`	⬇️

Files with missing lines	Coverage Δ
internal/rootcoord/alter_alias_task.go	`100.00% <100.00%> (ø)`
internal/rootcoord/alter_collection_task.go	`95.18% <100.00%> (+0.44%)`	⬆️
internal/rootcoord/alter_database_task.go	`87.35% <100.00%> (+0.77%)`	⬆️
internal/rootcoord/create_alias_task.go	`100.00% <100.00%> (ø)`
internal/rootcoord/create_collection_task.go	`90.27% <100.00%> (+0.09%)`	⬆️
internal/rootcoord/create_db_task.go	`84.21% <100.00%> (+1.85%)`	⬆️
internal/rootcoord/create_partition_task.go	`91.30% <100.00%> (+0.71%)`	⬆️
internal/rootcoord/describe_collection_task.go	`87.50% <100.00%> (+5.14%)`	⬆️
internal/rootcoord/describe_db_task.go	`100.00% <100.00%> (ø)`
internal/rootcoord/drop_alias_task.go	`100.00% <100.00%> (ø)`
... and 13 more

... and 319 files with indirect coverage changes

mergify · 2024-11-01T07:16:16Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

internal/rootcoord/create_collection_task.go

xiaofan-luan

Good job!
very excited about this!

xiaofan-luan · 2024-11-03T23:02:57Z

/lgtm
/approve

xiaofan-luan · 2024-11-03T23:03:39Z

@SimFG just let this pr so @wangting0128 could test on the concurrent DDL case

xiaofan-luan · 2024-11-03T23:04:02Z

I don't have a strong reason we can clean the cache on collection created

mergify · 2024-11-04T08:26:54Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify · 2024-11-04T09:58:45Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

xiaofan-luan · 2024-11-04T22:41:48Z

/lgtm
/approve

sre-ci-robot · 2024-11-04T22:41:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [xiaofan-luan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mergify · 2024-11-05T08:24:45Z

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify · 2024-11-05T08:56:55Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

SimFG · 2024-11-05T09:22:34Z

/run-cpu-e2e

SimFG · 2024-11-05T09:22:42Z

rerun go-sdk

mergify · 2024-11-05T10:28:32Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

SimFG · 2024-11-05T11:30:28Z

rerun ut

SimFG · 2024-11-05T11:39:33Z

/run-cpu-e2e

mergify · 2024-11-05T12:27:17Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

SimFG · 2024-11-05T14:54:17Z

/run-cpu-e2e

SimFG · 2024-11-05T14:54:35Z

rerun ut

mergify · 2024-11-05T14:58:42Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

SimFG · 2024-11-06T01:59:30Z

rerun ut

SimFG · 2024-11-06T01:59:38Z

/run-cpu-e2e

mergify · 2024-11-06T02:19:33Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

SimFG · 2024-11-06T02:20:19Z

/run-cpu-e2e

mergify · 2024-11-06T02:59:10Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

SimFG · 2024-11-06T03:06:10Z

/run-cpu-e2e

Signed-off-by: SimFG <[email protected]>

jaime0815 · 2024-11-06T06:46:23Z

/lgtm

- issue: #30301 - pr: #37352 Signed-off-by: SimFG <[email protected]>

sre-ci-robot requested review from bigsheeper and godchen0212 November 1, 2024 04:32

sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 1, 2024

mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 1, 2024

SimFG force-pushed the master-lock branch from 99010aa to c530d83 Compare November 1, 2024 06:19

xiaofan-luan reviewed Nov 1, 2024

View reviewed changes

internal/rootcoord/create_collection_task.go Show resolved Hide resolved

xiaofan-luan reviewed Nov 1, 2024

View reviewed changes

bigsheeper mentioned this pull request Nov 2, 2024

[Bug]: [Nightly] Load collection occasionally failed for timeout #37272

Closed

1 task

sre-ci-robot assigned xiaofan-luan Nov 3, 2024

sre-ci-robot added lgtm approved labels Nov 3, 2024

SimFG force-pushed the master-lock branch from c530d83 to 1002beb Compare November 4, 2024 07:23

sre-ci-robot added area/dependency Pull requests that update a dependency file size/XL Denotes a PR that changes 500-999 lines. and removed lgtm size/L Denotes a PR that changes 100-499 lines. labels Nov 4, 2024

SimFG force-pushed the master-lock branch from 1002beb to 604d9d1 Compare November 4, 2024 09:13

sre-ci-robot added the lgtm label Nov 4, 2024

SimFG force-pushed the master-lock branch from 604d9d1 to 6cabb53 Compare November 5, 2024 07:54

sre-ci-robot removed the lgtm label Nov 5, 2024

enhance: improve rootcoord task scheduling policy

b746aa3

Signed-off-by: SimFG <[email protected]>

SimFG force-pushed the master-lock branch from 6cabb53 to b746aa3 Compare November 6, 2024 03:57

mergify bot added the ci-passed label Nov 6, 2024

sre-ci-robot assigned jaime0815 Nov 6, 2024

sre-ci-robot added the lgtm label Nov 6, 2024

sre-ci-robot merged commit f1dd55e into milvus-io:master Nov 6, 2024
20 checks passed

SimFG mentioned this pull request Nov 8, 2024

enhance: [2.4] improve rootcoord task scheduling policy #37523

Merged

sre-ci-robot pushed a commit that referenced this pull request Nov 8, 2024

enhance: [2.4] improve rootcoord task scheduling policy (#37523)

5c166a2

- issue: #30301 - pr: #37352 Signed-off-by: SimFG <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enhance: improve rootcoord task scheduling policy #37352

enhance: improve rootcoord task scheduling policy #37352

SimFG commented Nov 1, 2024

mergify bot commented Nov 1, 2024

mergify bot commented Nov 1, 2024

mergify bot commented Nov 1, 2024

codecov bot commented Nov 1, 2024 •

edited

Loading

mergify bot commented Nov 1, 2024

xiaofan-luan left a comment

xiaofan-luan commented Nov 3, 2024

xiaofan-luan commented Nov 3, 2024

xiaofan-luan commented Nov 3, 2024

mergify bot commented Nov 4, 2024

mergify bot commented Nov 4, 2024

xiaofan-luan commented Nov 4, 2024

sre-ci-robot commented Nov 4, 2024

mergify bot commented Nov 5, 2024

mergify bot commented Nov 5, 2024

SimFG commented Nov 5, 2024

SimFG commented Nov 5, 2024

mergify bot commented Nov 5, 2024

SimFG commented Nov 5, 2024

SimFG commented Nov 5, 2024

mergify bot commented Nov 5, 2024

SimFG commented Nov 5, 2024

SimFG commented Nov 5, 2024

mergify bot commented Nov 5, 2024

SimFG commented Nov 6, 2024

SimFG commented Nov 6, 2024

mergify bot commented Nov 6, 2024

SimFG commented Nov 6, 2024

mergify bot commented Nov 6, 2024

SimFG commented Nov 6, 2024

jaime0815 commented Nov 6, 2024

enhance: improve rootcoord task scheduling policy #37352

enhance: improve rootcoord task scheduling policy #37352

Conversation

SimFG commented Nov 1, 2024

mergify bot commented Nov 1, 2024

mergify bot commented Nov 1, 2024

mergify bot commented Nov 1, 2024

codecov bot commented Nov 1, 2024 • edited Loading

Codecov Report

mergify bot commented Nov 1, 2024

xiaofan-luan left a comment

Choose a reason for hiding this comment

xiaofan-luan commented Nov 3, 2024

xiaofan-luan commented Nov 3, 2024

xiaofan-luan commented Nov 3, 2024

mergify bot commented Nov 4, 2024

mergify bot commented Nov 4, 2024

xiaofan-luan commented Nov 4, 2024

sre-ci-robot commented Nov 4, 2024

mergify bot commented Nov 5, 2024

mergify bot commented Nov 5, 2024

SimFG commented Nov 5, 2024

SimFG commented Nov 5, 2024

mergify bot commented Nov 5, 2024

SimFG commented Nov 5, 2024

SimFG commented Nov 5, 2024

mergify bot commented Nov 5, 2024

SimFG commented Nov 5, 2024

SimFG commented Nov 5, 2024

mergify bot commented Nov 5, 2024

SimFG commented Nov 6, 2024

SimFG commented Nov 6, 2024

mergify bot commented Nov 6, 2024

SimFG commented Nov 6, 2024

mergify bot commented Nov 6, 2024

SimFG commented Nov 6, 2024

jaime0815 commented Nov 6, 2024

codecov bot commented Nov 1, 2024 •

edited

Loading