Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add segment,pipeline, replica and resourcegroup api for WebUI #37344

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

jaime0815
Copy link
Contributor

issue: #36621

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Oct 31, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Oct 31, 2024
Copy link
Contributor

mergify bot commented Nov 1, 2024

@jaime0815 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 1, 2024

@jaime0815 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 1, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 1, 2024

@jaime0815 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 1, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 73.76491% with 154 lines in your changes missing coverage. Please review.

Project coverage is 80.98%. Comparing base (0c4321c) to head (6863903).
Report is 30 commits behind head on master.

Files with missing lines Patch % Lines
internal/datacoord/metrics_info.go 69.23% 26 Missing and 2 partials ⚠️
internal/querycoordv2/server.go 30.76% 12 Missing and 6 partials ⚠️
internal/querycoordv2/handlers.go 68.57% 8 Missing and 3 partials ⚠️
internal/datacoord/server.go 23.07% 7 Missing and 3 partials ⚠️
internal/flushcommon/util/timetick_sender.go 0.00% 9 Missing ⚠️
...nternal/flushcommon/pipeline/flow_graph_manager.go 82.22% 6 Missing and 2 partials ⚠️
internal/querycoordv2/meta/segment_dist_manager.go 65.21% 7 Missing and 1 partial ⚠️
internal/querycoordv2/meta/target_manager.go 57.89% 6 Missing and 2 partials ⚠️
internal/querynodev2/metrics_info.go 79.48% 6 Missing and 2 partials ⚠️
internal/querycoordv2/meta/dist_manager.go 65.00% 5 Missing and 2 partials ⚠️
... and 9 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37344      +/-   ##
==========================================
- Coverage   80.99%   80.98%   -0.02%     
==========================================
  Files        1305     1305              
  Lines      182879   183384     +505     
==========================================
+ Hits       148129   148519     +390     
- Misses      29549    29627      +78     
- Partials     5201     5238      +37     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.17% <ø> (ø)
Go 83.23% <73.76%> (-0.03%) ⬇️
Files with missing lines Coverage Δ
internal/datacoord/channel_manager.go 87.31% <100.00%> (+0.29%) ⬆️
internal/datacoord/index_meta.go 95.91% <ø> (ø)
internal/datacoord/meta.go 89.20% <100.00%> (+0.16%) ⬆️
internal/datacoord/stats_task_meta.go 77.51% <ø> (ø)
internal/flushcommon/metacache/segment.go 96.61% <100.00%> (+0.24%) ⬆️
internal/flushcommon/syncmgr/task.go 82.37% <100.00%> (+0.06%) ⬆️
internal/proxy/impl.go 85.38% <100.00%> (+0.02%) ⬆️
internal/querycoordv2/meta/channel_dist_manager.go 92.77% <100.00%> (+0.71%) ⬆️
internal/querycoordv2/meta/target.go 94.95% <100.00%> (+0.61%) ⬆️
internal/querynodev2/pipeline/pipeline.go 78.57% <100.00%> (+1.64%) ⬆️
... and 24 more

... and 32 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Nov 2, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 2, 2024

@jaime0815 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 2, 2024

@jaime0815 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 2, 2024

@jaime0815 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 2, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 2, 2024

@jaime0815 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 4, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 4, 2024

@jaime0815 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 4, 2024

@jaime0815 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 4, 2024

@jaime0815 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 4, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 4, 2024

@jaime0815 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@jaime0815
Copy link
Contributor Author

rerun cpp-unit-test

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 4, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 4, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815 jaime0815 force-pushed the webui-node branch 2 times, most recently from 02eacab to ee4030a Compare November 4, 2024 10:02
Copy link
Contributor

mergify bot commented Nov 4, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815 jaime0815 force-pushed the webui-node branch 2 times, most recently from f51dde0 to a32cf51 Compare November 4, 2024 11:55
Copy link
Contributor

mergify bot commented Nov 4, 2024

@jaime0815 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 4, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 5, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 5, 2024

@jaime0815 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@jaime0815
Copy link
Contributor Author

rerun cpp-unit-test

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 5, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 5, 2024
Copy link
Contributor

@SimFG SimFG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit f348bd9 into milvus-io:master Nov 7, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants