Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Use ts as msgID for request #37322

Closed
wants to merge 1 commit into from

Conversation

xiaocai2333
Copy link
Contributor

@xiaocai2333 xiaocai2333 commented Oct 31, 2024

issue: #37431

  1. Only search/query requests with a consistency level other than strong will skip timestamp assignment.
  2. MsgID holds little significance for search/query, so duplication is acceptable.

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 31, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 31, 2024
Copy link
Contributor

mergify bot commented Oct 31, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 31, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.98%. Comparing base (0fc6c63) to head (1b11ecb).
Report is 22 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37322       +/-   ##
===========================================
+ Coverage   67.19%   80.98%   +13.79%     
===========================================
  Files         290     1305     +1015     
  Lines       25426   182881   +157455     
===========================================
+ Hits        17084   148115   +131031     
- Misses       8342    29565    +21223     
- Partials        0     5201     +5201     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.17% <ø> (-0.02%) ⬇️
Go 83.24% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/proxy/meta_cache.go 88.88% <ø> (ø)
internal/proxy/task_scheduler.go 94.52% <100.00%> (ø)

... and 1014 files with indirect coverage changes

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 1, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Nov 2, 2024
Copy link
Contributor

mergify bot commented Nov 2, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 2, 2024

@xiaocai2333 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 2, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 2, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 2, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@xiaocai2333
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Nov 4, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@xiaofan-luan
Copy link
Collaborator

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaocai2333, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Nov 5, 2024
Copy link
Contributor

mergify bot commented Nov 5, 2024

@xiaocai2333 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Nov 5, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 5, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@xiaocai2333
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Nov 5, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Nov 5, 2024
@xiaocai2333
Copy link
Contributor Author

/hold

@czs007
Copy link
Collaborator

czs007 commented Nov 7, 2024

taskID is used in map, it's dangerous to use ts as ID.

@xiaocai2333
Copy link
Contributor Author

Perhaps in the future, we could replace ID allocation from rootcoord with a local auto-increment approach.
close it first。
/close

@sre-ci-robot
Copy link
Contributor

@xiaocai2333: Closed this PR.

In response to this:

Perhaps in the future, we could replace ID allocation from rootcoord with a local auto-increment approach.
close it first。
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xiaocai2333 xiaocai2333 deleted the use_ts_as_msgID branch November 8, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. do-not-merge/hold kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants