-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Use ts as msgID for request #37322
Conversation
@xiaocai2333 E2e jenkins job failed, comment |
@xiaocai2333 go-sdk check failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #37322 +/- ##
===========================================
+ Coverage 67.19% 80.98% +13.79%
===========================================
Files 290 1305 +1015
Lines 25426 182881 +157455
===========================================
+ Hits 17084 148115 +131031
- Misses 8342 29565 +21223
- Partials 0 5201 +5201
|
/run-cpu-e2e |
@xiaocai2333 E2e jenkins job failed, comment |
edc0ba7
to
688a31e
Compare
688a31e
to
358929d
Compare
@xiaocai2333 go-sdk check failed, comment |
@xiaocai2333 cpp-unit-test check failed, comment |
@xiaocai2333 E2e jenkins job failed, comment |
358929d
to
7da6a38
Compare
@xiaocai2333 go-sdk check failed, comment |
@xiaocai2333 E2e jenkins job failed, comment |
/run-cpu-e2e |
rerun go-sdk |
@xiaocai2333 go-sdk check failed, comment |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiaocai2333, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Cai Zhang <[email protected]>
7da6a38
to
1b11ecb
Compare
@xiaocai2333 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
@xiaocai2333 go-sdk check failed, comment |
@xiaocai2333 E2e jenkins job failed, comment |
/run-cpu-e2e |
rerun go-sdk |
@xiaocai2333 go-sdk check failed, comment |
rerun go-sdk |
/hold |
taskID is used in map, it's dangerous to use ts as ID. |
Perhaps in the future, we could replace ID allocation from rootcoord with a local auto-increment approach. |
@xiaocai2333: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
issue: #37431
MsgID
holds little significance for search/query, so duplication is acceptable.