Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [cp25]Saperate L0 and Mix trigger interval #37321

Closed
wants to merge 5 commits into from
Closed

fix: [cp25]Saperate L0 and Mix trigger interval #37321

wants to merge 5 commits into from

Conversation

XuanYang-cn
Copy link
Contributor

See also: #37108
pr: #37190

  • Add MixCompactionTriggerInterval, default 60s
  • Add L0CompactionTriggerInterval, default 10s
  • Export Single related compaction configs
  • Raise SingleCompactionDeltaLogMaxSize from 2MB to 16MB

@XuanYang-cn
fix: [cp25]Saperate L0 and Mix trigger interval
0abdc42 
See also: milvus-io#37108
pr: milvus-io#37190

- Add MixCompactionTriggerInterval, default 60s
- Add L0CompactionTriggerInterval, default 10s
- Export Single related compaction configs
- Raise SingleCompactionDeltaLogMaxSize from 2MB to 16MB

Signed-off-by: yangxuan <[email protected]>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Oct 31, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: XuanYang-cn
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Oct 31, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 31, 2024

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.84%. Comparing base (8ba0a4a) to head (116bf50).

❗ Current head 116bf50 differs from pull request most recent head 425fa16

Please upload reports for the commit 425fa16 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #37321      +/-   ##
==========================================
- Coverage   80.95%   80.84%   -0.11%     
==========================================
  Files        1305     1322      +17     
  Lines      182900   183234     +334     
==========================================
+ Hits       148069   148143      +74     
- Misses      29627    29886     +259     
- Partials     5204     5205       +1
Components Coverage Δ
Client ∅ <0.00%> (∅)
Core 66.92% <0.00%> (ø)
Go 83.11% <0.00%> (-0.14%) ⬇️

see 40 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 31, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Nov 4, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun go-sdk

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@XuanYang-cn XuanYang-cn closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cydrain cydrain Awaiting requested review from cydrain

@czs007 czs007 Awaiting requested review from czs007

Assignees
No one assigned
Labels
area/test dco-passed DCO check passed. kind/bug Issues or changes related a bug sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XuanYang-cn @sre-ci-robot