Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add SearchOnSealed unit test and fix a bug (#37241) #37293

Closed
wants to merge 1 commit into from
Closed

fix: add SearchOnSealed unit test and fix a bug (#37241) #37293

wants to merge 1 commit into from

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Oct 30, 2024

issue: #37244

@sre-ci-robot sre-ci-robot added area/compilation size/L Denotes a PR that changes 100-499 lines. labels Oct 30, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunby
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 30, 2024

@sunby Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added dco-passed DCO check passed. do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Oct 30, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.90%. Comparing base (ee6ce8c) to head (552b10e).
Report is 25 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #37293      +/-   ##
==========================================
- Coverage   83.14%   80.90%   -2.24%     
==========================================
  Files        1029     1319     +290     
  Lines      157291   182771   +25480     
==========================================
+ Hits       130778   147870   +17092     
- Misses      21342    29728    +8386     
- Partials     5171     5173       +2
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.15% <100.00%> (∅)
Go 83.15% <ø> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/mmap/ChunkedColumn.h 9.23% <100.00%> (ø)
internal/core/src/query/SearchOnSealed.cpp 95.19% <100.00%> (ø)

... and 320 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Oct 30, 2024
xiaofan-luan
xiaofan-luan reviewed Oct 31, 2024
View reviewed changes
internal/core/src/query/SearchOnSealed.cpp
search_info,
bitset_view,
data_type);
for (auto& o : sub_qr.mutable_seg_offsets()) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be super ugly.

can we simply by pass a result the resultset to knowhere and let knowhere fill it inside?

@liliu-z please help on this. also it doesn't make sense to cp the the bitset if it's not aligned

@xiaofan-luan
Copy link
Collaborator

hold this pr a while.
@sunby please discuss with @liliu-z guess we need to solve this in one run

@liliu-z
Copy link
Member

liliu-z commented Nov 4, 2024

@cqy123456 is working on this.

@sunby
Copy link
Contributor Author

sunby commented Nov 5, 2024

2.5 branch has been deleted, this pr will be closed.

@sunby sunby closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaofan-luan xiaofan-luan xiaofan-luan left review comments

@godchen0212 godchen0212 Awaiting requested review from godchen0212

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees
No one assigned
Labels
area/compilation ci-passed dco-passed DCO check passed. do-not-merge/missing-related-pr kind/bug Issues or changes related a bug size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunby @sre-ci-robot @xiaofan-luan @liliu-z