Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added proper return messages for drop tasks #37251

Closed
wants to merge 2 commits into from

Conversation

nish112022
Copy link
Contributor

issue: #37249

This is for drop collection,drop partition and drop index tasks

@sre-ci-robot sre-ci-robot requested review from cydrain and yhmo October 29, 2024 08:31
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 29, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Oct 29, 2024
Copy link
Contributor

mergify bot commented Oct 29, 2024

@nish112022 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@nish112022
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Oct 29, 2024

@nish112022 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 29, 2024

@nish112022 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.99%. Comparing base (86b9c3e) to head (09495df).
Report is 39 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37251      +/-   ##
==========================================
- Coverage   83.15%   80.99%   -2.17%     
==========================================
  Files        1029     1305     +276     
  Lines      157251   182871   +25620     
==========================================
+ Hits       130764   148114   +17350     
- Misses      21322    29557    +8235     
- Partials     5165     5200      +35     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.17% <ø> (∅)
Go 83.25% <100.00%> (+0.06%) ⬆️
Files with missing lines Coverage Δ
internal/datacoord/index_service.go 92.93% <100.00%> (ø)
internal/rootcoord/drop_collection_task.go 100.00% <100.00%> (ø)
internal/rootcoord/drop_partition_task.go 100.00% <100.00%> (ø)

... and 365 files with indirect coverage changes

@nish112022
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Oct 29, 2024

@nish112022 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 30, 2024

@nish112022 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 30, 2024

@nish112022 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@nish112022
Copy link
Contributor Author

rerun go-sdk

1 similar comment
@nish112022
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Nov 2, 2024

@nish112022 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@nish112022
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Nov 3, 2024

@nish112022 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nish112022
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. area/test sig/testing and removed size/XS Denotes a PR that changes 0-9 lines. labels Nov 3, 2024
Copy link
Contributor

mergify bot commented Nov 3, 2024

@nish112022 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 3, 2024

@nish112022 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 3, 2024

@nish112022 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 3, 2024

@nish112022 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@nish112022
Copy link
Contributor Author

/run-cpu-e2e
rerun cpp-unit-test

Copy link
Contributor

mergify bot commented Nov 3, 2024

@nish112022 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 3, 2024

@nish112022 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 3, 2024

@nish112022 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 3, 2024

@nish112022 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 3, 2024

@nish112022 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 3, 2024

@nish112022 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@nish112022
Copy link
Contributor Author

rerun go-sdk

@nish112022
Copy link
Contributor Author

rerun cpp-unit-test

@nish112022
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 3, 2024

@nish112022 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@nish112022
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 3, 2024

@nish112022 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@nish112022 nish112022 closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test dco-passed DCO check passed. kind/bug Issues or changes related a bug sig/testing size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants