Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] Search for pk using raw data to reduce the overhead caused by views #37203

Closed
wants to merge 1 commit into from

Conversation

xiaocai2333
Copy link
Contributor

issue: #37152

master pr: #37202

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiaocai2333
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Oct 28, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Oct 28, 2024
Copy link
Contributor

mergify bot commented Oct 28, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 54 lines in your changes missing coverage. Please review.

Project coverage is 80.88%. Comparing base (116bf50) to head (d47710e).
Report is 6 commits behind head on 2.5.

Files with missing lines Patch % Lines
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 0.00% 20 Missing ⚠️
internal/core/src/common/Chunk.h 0.00% 19 Missing ⚠️
internal/core/src/mmap/Column.h 0.00% 10 Missing ⚠️
internal/core/src/segcore/SegmentSealedImpl.cpp 75.00% 4 Missing ⚠️
internal/core/src/mmap/ChunkedColumn.h 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #37203      +/-   ##
==========================================
+ Coverage   80.84%   80.88%   +0.03%     
==========================================
  Files        1322     1322              
  Lines      183234   183175      -59     
==========================================
+ Hits       148143   148155      +12     
+ Misses      29886    29821      -65     
+ Partials     5205     5199       -6     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.05% <18.18%> (+0.12%) ⬆️
Go 83.12% <ø> (+0.01%) ⬆️
Files with missing lines Coverage Δ
...ternal/core/src/segcore/ChunkedSegmentSealedImpl.h 0.00% <ø> (ø)
internal/core/src/segcore/SegmentSealedImpl.h 37.93% <ø> (ø)
internal/core/src/mmap/ChunkedColumn.h 0.00% <0.00%> (ø)
internal/core/src/segcore/SegmentSealedImpl.cpp 85.30% <75.00%> (+1.32%) ⬆️
internal/core/src/mmap/Column.h 88.15% <0.00%> (-2.63%) ⬇️
internal/core/src/common/Chunk.h 49.39% <0.00%> (-13.68%) ⬇️
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 0.00% <0.00%> (ø)

... and 24 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Oct 29, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 29, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 29, 2024

@xiaocai2333 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@xiaocai2333 xiaocai2333 changed the title fix: [cherry-pick] Search for pk using raw data to reduce the overhead caused by views fix: [2.5] Search for pk using raw data to reduce the overhead caused by views Oct 30, 2024
@xiaocai2333 xiaocai2333 added this to the 2.5.0 milestone Oct 30, 2024
Copy link
Contributor

mergify bot commented Oct 30, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 30, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 30, 2024

@xiaocai2333 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 31, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 2, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Nov 2, 2024
@xiaocai2333
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Nov 4, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@xiaofan-luan
Copy link
Collaborator

close it becasue 2.5 branch will be recreated.

@xiaocai2333 xiaocai2333 deleted the fix_views_copy-5 branch November 8, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants