Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Tokenizer support build with params and clone for concurrency #37048

Merged
merged 4 commits into from
Nov 6, 2024
Merged

feat: Tokenizer support build with params and clone for concurrency #37048

merged 4 commits into from
Nov 6, 2024

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Oct 22, 2024

relate: #35853 #36751

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Oct 22, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Oct 22, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 22, 2024

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 22, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 22, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 22, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 23, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@aoiasd aoiasd force-pushed the doc-in-tokenizer branch 2 times, most recently from b27ae69 to c21cbfd Compare October 23, 2024 06:26
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Oct 23, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 23, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 23, 2024

@aoiasd cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 23, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 24, 2024

@aoiasd cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 24, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 24, 2024

@aoiasd cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Nov 5, 2024

rerun cpp-unit-test

@aoiasd
Copy link
Contributor Author

aoiasd commented Nov 5, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Nov 5, 2024

/run-cpu-e2e

1 similar comment
@aoiasd
Copy link
Contributor Author

aoiasd commented Nov 5, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@aoiasd cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Nov 5, 2024

/run-cpu-e2e

@aoiasd
Copy link
Contributor Author

aoiasd commented Nov 5, 2024

rerun cpp-unit-test

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@aoiasd cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Nov 5, 2024

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Nov 5, 2024

/run-cpu-e2e

@aoiasd
Copy link
Contributor Author

aoiasd commented Nov 5, 2024

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Nov 6, 2024
@czs007
Copy link
Collaborator

czs007 commented Nov 6, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d67853f into milvus-io:master Nov 6, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhengbuqian zhengbuqian zhengbuqian left review comments

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@czs007 czs007 Awaiting requested review from czs007

Assignees

@czs007 czs007

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm sig/testing size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aoiasd @czs007 @sre-ci-robot @zhengbuqian