fix: Search may return less result after qn recover #36549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
dco-passed
|
@weiliu1031 E2e jenkins job failed, comment |
|
@weiliu1031 go-sdk check failed, comment |
1 similar comment
|
@weiliu1031 go-sdk check failed, comment |
|
@weiliu1031 E2e jenkins job failed, comment |
weiliu1031
force-pushed
the
fix_search_return_less_result
branch
from
4721bd6 to
deffc47
Compare
sre-ci-robot
added
size/L
|
@weiliu1031 E2e jenkins job failed, comment |
|
@weiliu1031 go-sdk check failed, comment |
weiliu1031
force-pushed
the
fix_search_return_less_result
branch
from
deffc47 to
bfef2b8
Compare
|
@weiliu1031 E2e jenkins job failed, comment |
|
@weiliu1031 go-sdk check failed, comment |
|
rerun go-sdk |
|
@weiliu1031 go-sdk check failed, comment |
1 similar comment
|
@weiliu1031 go-sdk check failed, comment |
|
@weiliu1031 E2e jenkins job failed, comment |
weiliu1031
force-pushed
the
fix_search_return_less_result
branch
from
bfef2b8 to
2e8956b
Compare
|
@weiliu1031 go-sdk check failed, comment |
weiliu1031
force-pushed
the
fix_search_return_less_result
branch
from
2e8956b to
0b5a906
Compare
|
@weiliu1031 go-sdk check failed, comment |
|
@weiliu1031 E2e jenkins job failed, comment |
weiliu1031
force-pushed
the
fix_search_return_less_result
branch
4 times, most recently
from
160a3e3 to
53c1b7e
Compare
Signed-off-by: Wei Liu <[email protected]>
weiliu1031
force-pushed
the
fix_search_return_less_result
branch
from
91e4ce5 to
04cbc6c
Compare
bigsheeper
reviewed
Nov 11, 2024
Signed-off-by: Wei Liu <[email protected]>
|
/lgtm |
|
related: #37364 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, weiliu1031 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
weiliu1031
added a commit
to weiliu1031/milvus
that referenced
this pull request
Nov 12, 2024
issue: milvus-io#36293 milvus-io#36242 after qn recover, delegator may be loaded in new node, after all segment has been loaded, delegator becomes serviceable. but delegator's target version hasn't been synced, and if search/query comes, delegator will use wrong target version to filter out a empty segment list, which caused empty search result. This pr will block delegator's serviceable status until target version is synced --------- Signed-off-by: Wei Liu <[email protected]>
weiliu1031
added a commit
to weiliu1031/milvus
that referenced
this pull request
Nov 12, 2024
issue: milvus-io#36293 milvus-io#36242 after qn recover, delegator may be loaded in new node, after all segment has been loaded, delegator becomes serviceable. but delegator's target version hasn't been synced, and if search/query comes, delegator will use wrong target version to filter out a empty segment list, which caused empty search result. This pr will block delegator's serviceable status until target version is synced --------- Signed-off-by: Wei Liu <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Nov 12, 2024
issue: #36293 #36242 pr: #36549 after qn recover, delegator may be loaded in new node, after all segment has been loaded, delegator becomes serviceable. but delegator's target version hasn't been synced, and if search/query comes, delegator will use wrong target version to filter out a empty segment list, which caused empty search result. This pr will block delegator's serviceable status until target version is synced --------- Signed-off-by: Wei Liu <[email protected]>
This was referenced Nov 13, 2024
sre-ci-robot
pushed a commit
that referenced
this pull request
Nov 13, 2024
) issue: #37640 pr: #37641 fix the pr #36549 cause balance channel will wait until new delegator becomes serviceable, but new delegator need to sync target version then becomes serviceable, and sync target version need to be wait all replica load done. so if increasing replica number and balance channel happens at same time, logic dead lock occurs. Signed-off-by: Wei Liu <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Nov 14, 2024
) issue: #37640 fix the pr #36549 cause balance channel will wait until new delegator becomes serviceable, but new delegator need to sync target version then becomes serviceable, and sync target version need to be wait all replica load done. so if increasing replica number and balance channel happens at same time, logic dead lock occurs. Signed-off-by: Wei Liu <[email protected]>
weiliu1031
added a commit
to weiliu1031/milvus
that referenced
this pull request
Nov 14, 2024
pr milvus-io#36549 introduce the logic error which update current target when only parts of channel is ready. This PR fix the logic error and let dist handler keep pull distribution on querynode until all delegator becomes serviceable. Signed-off-by: Wei Liu <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Nov 15, 2024
issue: #37679 pr #36549 introduce the logic error which update current target when only parts of channel is ready. This PR fix the logic error and let dist handler keep pull distribution on querynode until all delegator becomes serviceable. Signed-off-by: Wei Liu <[email protected]>
weiliu1031
added a commit
to weiliu1031/milvus
that referenced
this pull request
Nov 15, 2024
issue: milvus-io#37679 pr milvus-io#36549 introduce the logic error which update current target when only parts of channel is ready. This PR fix the logic error and let dist handler keep pull distribution on querynode until all delegator becomes serviceable. Signed-off-by: Wei Liu <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Nov 15, 2024
issue: #37679 pr: #37694 pr #36549 introduce the logic error which update current target when only parts of channel is ready. This PR fix the logic error and let dist handler keep pull distribution on querynode until all delegator becomes serviceable. Signed-off-by: Wei Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #36293 #36242
after qn recover, delegator may be loaded in new node, after all segment has been loaded, delegator becomes serviceable. but delegator's target version hasn't been synced, and if search/query comes, delegator will use wrong target version to filter out a empty segment list, which caused empty search result.
This pr will block delegator's serviceable status until target version is synced