Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: variable column batch size too big #35013

Closed
1 task done
zhagnlu opened this issue Jul 25, 2024 · 2 comments
Closed
1 task done

[Bug]: variable column batch size too big #35013

zhagnlu opened this issue Jul 25, 2024 · 2 comments
Assignees
@zhagnlu
Labels
kind/bug Issues or changes related a bug stale indicates no udpates for 30 days triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@zhagnlu
Copy link
Contributor

zhagnlu commented Jul 25, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version:
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

for variable column, to save memory, optimize it column struct, but internal batch size is too big, get a high cpu for retrieve data as a result

Expected Behavior

No response

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@zhagnlu zhagnlu added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 25, 2024
@zhagnlu zhagnlu mentioned this issue Jul 25, 2024
Merged
czs007 pushed a commit that referenced this issue Jul 25, 2024
@zhagnlu
enhance: decrease variable column block size (#35012)
99da94e 
#35013

Signed-off-by: luzhang <[email protected]>
Co-authored-by: luzhang <[email protected]>
@zhagnlu zhagnlu mentioned this issue Jul 25, 2024
Closed
@yanliang567
Copy link
Contributor

/assign @zhagnlu
/unassign

@sre-ci-robot sre-ci-robot assigned zhagnlu and unassigned yanliang567 Jul 26, 2024
@yanliang567 yanliang567 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 26, 2024
@zhagnlu zhagnlu mentioned this issue Jul 26, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Jul 30, 2024
@zhagnlu
enhance: redefine variable column block size (#35040)
dd0c26c 
#35013

Signed-off-by: luzhang <[email protected]>
Co-authored-by: luzhang <[email protected]>
sumitd2 pushed a commit to sumitd2/milvus that referenced this issue Aug 6, 2024
@zhagnlu @sumitd2
enhance: redefine variable column block size (milvus-io#35040)
3b686cc 
milvus-io#35013

Signed-off-by: luzhang <[email protected]>
Co-authored-by: luzhang <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
@stale Stale
Copy link

stale bot commented Aug 25, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Aug 25, 2024
@stale stale bot closed this as completed Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhagnlu zhagnlu

Labels
kind/bug Issues or changes related a bug stale indicates no udpates for 30 days triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhagnlu @yanliang567