Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Datanode watch progress tickler not working #35008

Closed
1 task done
congqixia opened this issue Jul 25, 2024 · 1 comment
Closed
1 task done

[Bug]: Datanode watch progress tickler not working #35008

congqixia opened this issue Jul 25, 2024 · 1 comment
Assignees
@congqixia
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@congqixia
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: master &v2.4.6
- Deployment mode(standalone or cluster): both
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

Datanode watch progress can only execute within WatchTimeout duration. The progress tickler cannot work since the job context is cancelled

Expected Behavior

Progress tickler shall be able to work

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@congqixia congqixia added kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jul 25, 2024
@congqixia congqixia self-assigned this Jul 25, 2024
congqixia added a commit to congqixia/milvus that referenced this issue Jul 25, 2024
@congqixia
fix: Remove timeout in datanode watch ctx
fc7dcba 
See also milvus-io#35008

Use tickle timeout logic instead of hardcode context timeout

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue Jul 25, 2024
Merged
@XuanYang-cn
Copy link
Contributor

/lgtm

sre-ci-robot pushed a commit that referenced this issue Jul 25, 2024
@congqixia
fix: Remove timeout in datanode watch ctx (#35011)
e8038a7 
See also #35008

Use tickle timeout logic instead of hardcode context timeout

Signed-off-by: Congqi Xia <[email protected]>
congqixia added a commit to congqixia/milvus that referenced this issue Jul 26, 2024
@congqixia
fix: Remove timeout in datanode watch ctx (milvus-io#35011)
f5448e9 
See also milvus-io#35008

Use tickle timeout logic instead of hardcode context timeout

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue Jul 26, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Jul 26, 2024
@congqixia
fix: [2.4] Remove timeout in datanode watch ctx (#35011) (#35017)
2a43f43 
Cherry-pick from master
pr: #35011
See also #35008

Use tickle timeout logic instead of hardcode context timeout

Signed-off-by: Congqi Xia <[email protected]>
sumitd2 pushed a commit to sumitd2/milvus that referenced this issue Aug 6, 2024
@congqixia @sumitd2
fix: Remove timeout in datanode watch ctx (milvus-io#35011)
58e5474 
See also milvus-io#35008

Use tickle timeout logic instead of hardcode context timeout

Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
@xiaofan-luan xiaofan-luan mentioned this issue Aug 22, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@congqixia congqixia

Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@XuanYang-cn @congqixia