Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: skip creating index when there is no querynode #35004

Closed
1 task done
longjiquan opened this issue Jul 25, 2024 · 4 comments
Closed
1 task done

[Enhancement]: skip creating index when there is no querynode #35004

longjiquan opened this issue Jul 25, 2024 · 4 comments
Assignees
Labels
kind/enhancement Issues or changes related to enhancement

Comments

@longjiquan
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

Skip creating index when there is no querynode.

Why is this needed?

Avoid the index version rollbacked to 0.

Anything else?

No response

@longjiquan longjiquan added the kind/enhancement Issues or changes related to enhancement label Jul 25, 2024
@longjiquan longjiquan self-assigned this Jul 25, 2024
@xiaofan-luan
Copy link
Collaborator

why we skip create index when there is no qn?

@czs007
Copy link
Collaborator

czs007 commented Jul 28, 2024

@xiaofan-luan Currently ,we query the all the QueryNode to determine the index engine version of Knowhere.

@xiaofan-luan
Copy link
Collaborator

if there are no querynodes, simply use latest version as a fallback?

@xiaofan-luan
Copy link
Collaborator

assuming all the new brought up nodes should be new versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Issues or changes related to enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants