Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: GetQueryInfo return dropped segment dropped by L2 single compaction #35003

Open
1 task done
wayblink opened this issue Jul 25, 2024 · 2 comments
Open
1 task done

[Bug]: GetQueryInfo return dropped segment dropped by L2 single compaction #35003

wayblink opened this issue Jul 25, 2024 · 2 comments
Assignees
@wayblink
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
2.4.21

Comments

@wayblink
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: master/2.4
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

GetQueryInfo return dropped segment dropped by L2 single compaction because we regard a dropped segment as valid if it is L2 and its partitionStatsVersion == currentPartitionStatsVersion. This is to handle the indexing stage of clustering compaction
https://github.com/milvus-io/milvus/blob/63f0154dfb420b68c18b8a41dd8830633327495c/internal/datacoord/handler.go#L157-#L166

Expected Behavior

No response

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@wayblink wayblink added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 25, 2024
@wayblink
Copy link
Contributor Author

/assign

@wayblink
Copy link
Contributor Author

/unassgin @yanliang567

@wayblink wayblink mentioned this issue Jul 25, 2024
Merged
@yanliang567 yanliang567 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 26, 2024
@yanliang567 yanliang567 added this to the 2.4.7 milestone Jul 26, 2024
@yanliang567 yanliang567 removed their assignment Jul 26, 2024
sre-ci-robot pushed a commit that referenced this issue Jul 26, 2024
@wayblink
fix: [cherry-pick] fix dropped segment still visible after dropped by…
1e5c71d 
… L2 single compaction (#35006)

bug: #35003

Signed-off-by: wayblink <[email protected]>
@wayblink wayblink mentioned this issue Jul 29, 2024
Merged
@yanliang567 yanliang567 modified the milestones: 2.4.7, 2.4.8 Aug 12, 2024
@yanliang567 yanliang567 modified the milestones: 2.4.8, 2.4.10 Aug 19, 2024
@yanliang567 yanliang567 modified the milestones: 2.4.10, 2.4.11 Sep 5, 2024
@yanliang567 yanliang567 modified the milestones: 2.4.11, 2.4.12 Sep 18, 2024
@yanliang567 yanliang567 modified the milestones: 2.4.12, 2.4.13 Sep 27, 2024
@yanliang567 yanliang567 modified the milestones: 2.4.13, 2.4.14 Oct 15, 2024
@yanliang567 yanliang567 modified the milestones: 2.4.14, 2.4.16 Nov 14, 2024
@yanliang567 yanliang567 modified the milestones: 2.4.16, 2.4.17 Nov 21, 2024
@yanliang567 yanliang567 added this to the 2.4.18 milestone Nov 25, 2024
@yanliang567 yanliang567 modified the milestones: 2.4.18, 2.4.19, 2.4.20 Dec 24, 2024
@yanliang567 yanliang567 modified the milestones: 2.4.20, 2.4.21 Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wayblink wayblink

Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
2.4.21
Development

No branches or pull requests
2 participants
@wayblink @yanliang567