Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cherry-pick] compaction task not be cleaned correctly #34766

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

wayblink
Copy link
Contributor

1.fix compaction task not be cleaned correctly
2.add a new parameter to control compaction gc loop interval
3.remove some useless configs of clustering compaction

bug: #34764
pr: #34765

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jul 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jul 17, 2024
@wayblink wayblink force-pushed the fix-compaction-gc-2.4 branch from 92755bf to 5ddfcca Compare July 17, 2024 10:33
Copy link
Contributor

mergify bot commented Jul 17, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1.fix compaction task not be cleaned correctly
2.add a new parameter to control compaction gc loop interval
3.remove some useless configs of clustering compaction

Signed-off-by: wayblink <[email protected]>
@wayblink wayblink force-pushed the fix-compaction-gc-2.4 branch from 5ddfcca to 85f1b31 Compare July 17, 2024 12:56
@wayblink wayblink added this to the 2.4.7 milestone Jul 17, 2024
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wayblink, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Jul 17, 2024
@sre-ci-robot sre-ci-robot merged commit 83fc26c into milvus-io:2.4 Jul 17, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants