Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Uprade etcd to 3.5.13, pulsar to 3.0.4 and minio to latest #32184

Closed
1 task done
xiaofan-luan opened this issue Apr 11, 2024 · 19 comments
Closed
1 task done
Assignees
Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days

Comments

@xiaofan-luan
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

The dependency for milvus is pretty old and there are critical issues to fixed

We we seen some of the critical issues related to dependency crash or data loss.

It's could help milvus service to be more stable and might also help the performance of insertion.

Why is this needed?

No response

Anything else?

No response

@xiaofan-luan xiaofan-luan added the kind/enhancement Issues or changes related to enhancement label Apr 11, 2024
@xiaofan-luan
Copy link
Collaborator Author

/assign @LoveEachDay

@xiaofan-luan xiaofan-luan changed the title [Enhancement]: Uprade etcd to 3.5.13, pulsar to 3.0.4 and minio to lastest [Enhancement]: Uprade etcd to 3.5.13, pulsar to 3.0.4 and minio to latest Apr 11, 2024
@LoveEachDay
Copy link
Contributor

@xiaofan-luan Our Pulsar 3.0.2 tests have been satisfactory, particularly in terms of broker load balancing. Is there any specific reason for upgrading to pulsar 3.0.4, which rolls out only ten days ago?

@xiaofan-luan
Copy link
Collaborator Author

@xiaofan-luan Our Pulsar 3.0.2 tests have been satisfactory, particularly in terms of broker load balancing. Is there any specific reason for upgrading to pulsar 3.0.4, which rolls out only ten days ago?

Since 3.0.4 is the latest version of 3.0.x, I'm assuming this is gonna to be more stable compare to 3.0.2

@lynnssi
Copy link

lynnssi commented May 7, 2024

Is there an ETA on releasing the upgrades to etcd/pulsar/minio?

If I upgraded these images on my own Milvus implementation before an official release, would Milvus continue to work as expected, or should I wait until the upgrade is formally released?

@xiaofan-luan
Copy link
Collaborator Author

it should be.
@LoveEachDay any comments on this?

@lynnssi
Copy link

lynnssi commented May 24, 2024

@LoveEachDay Any follow up here?

@lynnssi
Copy link

lynnssi commented May 30, 2024

Can you confirm whether the upgraded dependencies are compatible with the latest version of Milvus?

If not, is there an ETA on when Milvus will be compatible with the latest versions of etcd/pulsar/minio?

@xiaofan-luan
Copy link
Collaborator Author

xiaofan-luan commented Jun 1, 2024

I believe upgrade etcd/minio/pulsar dependencies should not be aware of the dependency version.

Copy link

stale bot commented Jul 1, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Jul 1, 2024
@lynnssi
Copy link

lynnssi commented Jul 5, 2024

/reopen
I have tried upgrading pulsar to version 3.0.4, but it appears that I need to also upgrade the helm chart in order for it to work. I have pulled the template for pulsar 3.0.0 from https://github.com/apache/pulsar-helm-chart/tree/pulsar-3.0.0, but am having some trouble.

@LoveEachDay could you share the pulsar helm chart that you used to do your testing?

It would be helpful to have this in a future Milvus release, as I am sure other users would like to use a more recent version of pulsar.

@stale stale bot removed the stale indicates no udpates for 30 days label Jul 5, 2024
@xiaofan-luan
Copy link
Collaborator Author

/reopen I have tried upgrading pulsar to version 3.0.4, but it appears that I need to also upgrade the helm chart in order for it to work. I have pulled the template for pulsar 3.0.0 from https://github.com/apache/pulsar-helm-chart/tree/pulsar-3.0.0, but am having some trouble.

@LoveEachDay could you share the pulsar helm chart that you used to do your testing?

It would be helpful to have this in a future Milvus release, as I am sure other users would like to use a more recent version of pulsar.

the issue here is pulsar 2.9 and 3.0 is not compatible.
all the existing customer need to stop service before the upgrade.

@xiaofan-luan
Copy link
Collaborator Author

We decide to upgrade to pulsar 3.0 at Milvus 2.5

Copy link

stale bot commented Aug 6, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Aug 6, 2024
@stale stale bot closed this as completed Aug 19, 2024
@lynnssi
Copy link

lynnssi commented Aug 22, 2024

@xiaofan-luan When can I expect to see Milvus 2.5 released?

@xiaofan-luan
Copy link
Collaborator Author

@xiaofan-luan When can I expect to see Milvus 2.5 released?

Currently the 2.5 code is almost there. The Target release date is mid September.

I think we hit some issue on can not rolling upgrade pulsar to 3.0.x smoothly? @LoveEachDay

@xiaofan-luan
Copy link
Collaborator Author

do we need to stop all service for user to upgrade?

If that's the case, my suggestion is to use 2.9.x by default on 2.5 (Given user an config option to use 3.0.x)
And upgrade pulsar to 3.0.2 by default in 3.0

@lynnssi
Copy link

lynnssi commented Aug 23, 2024

If pulsar 2.9.x is the default on 2.5, a user option to use 3.0.x would be really useful! I am keen to upgrade my pulsar version and would much prefer to do it through a user option in the helm chart.

@xiaofan-luan
Copy link
Collaborator Author

If pulsar 2.9.x is the default on 2.5, a user option to use 3.0.x would be really useful! I am keen to upgrade my pulsar version and would much prefer to do it through a user option in the helm chart.

That is definitely doable.

The reason is you will need to stop pulsar and made some change on the helm chart.

@xiaofan-luan
Copy link
Collaborator Author

so the upgrade to pulsar 3.0.x will be left to milvus 3.0.
We will have a recommened setup for pulsar 3.0.0x and how you can upgrade from 2.8/2.9 to 3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days
Projects
None yet
Development

No branches or pull requests

3 participants