Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename createindex #27903

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

jiaoew1991
Copy link
Contributor

/kind improvement

Signed-off-by: Enwei Jiao <[email protected]>
@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/XXL Denotes a PR that changes 1000+ lines. approved labels Oct 24, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Oct 24, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 24, 2023

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 24, 2023

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #27903 (f6b5c76) into master (e0222b2) will increase coverage by 0.00%.
Report is 12 commits behind head on master.
The diff coverage is 75.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #27903   +/-   ##
=======================================
  Coverage   81.76%   81.76%           
=======================================
  Files         821      812    -9     
  Lines      116330   116255   -75     
=======================================
- Hits        95115    95058   -57     
+ Misses      18051    18041   -10     
+ Partials     3164     3156    -8     
Files Coverage Δ
internal/util/indexcgowrapper/index.go 68.25% <100.00%> (+1.19%) ⬆️
internal/core/src/indexbuilder/index_c.cpp 29.73% <50.00%> (+0.54%) ⬆️

... and 166 files with indirect coverage changes

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, jiaoew1991

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [congqixia,jiaoew1991]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Oct 27, 2023
@sre-ci-robot sre-ci-robot merged commit 4a33391 into milvus-io:master Oct 27, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm manual-pass manually set pass before ci-passed labeled size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants