Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use temp binlog index replace binlog in querynode #27673

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

cqy123456
Copy link
Contributor

@cqy123456 cqy123456 commented Oct 12, 2023

issue: #27678
When querynode load vector binlog for a sealed segment, binlog fields will be replaced by a temperate binlog index for better search performance. And this binlog index will be released after loading vector index.
However, binlog needs to meet the following conditions:

  1. tempIndex = true in milvus.yaml;
  2. user call create_index api, and build segment index task is not finish in indexnode or indexpool;
  3. index type != flat;

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. area/internal-api labels Oct 12, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2023

@cqy123456 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2023

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2023

@cqy123456 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2023

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@cqy123456
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Oct 16, 2023

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Oct 16, 2023

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #27673 (58ce181) into master (ab6dbf7) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is 92.24%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #27673   +/-   ##
=======================================
  Coverage   81.81%   81.81%           
=======================================
  Files         820      820           
  Lines      116929   116995   +66     
=======================================
+ Hits        95663    95724   +61     
- Misses      18097    18101    +4     
- Partials     3169     3170    +1     
Files Coverage Δ
internal/core/src/segcore/FieldIndexing.cpp 57.86% <100.00%> (ø)
internal/core/src/segcore/FieldIndexing.h 70.75% <100.00%> (ø)
internal/core/src/segcore/IndexConfigGenerator.cpp 100.00% <100.00%> (ø)
internal/core/src/segcore/SegcoreConfig.h 86.36% <100.00%> (+13.63%) ⬆️
internal/core/src/segcore/SegmentGrowingImpl.cpp 83.06% <100.00%> (ø)
internal/core/src/segcore/SegmentSealedImpl.h 89.47% <100.00%> (+0.58%) ⬆️
internal/core/src/segcore/segcore_init_c.cpp 42.85% <100.00%> (+9.52%) ⬆️
internal/core/src/segcore/segment_c.cpp 66.31% <100.00%> (ø)
internal/querynodev2/server.go 65.12% <100.00%> (ø)
pkg/util/paramtable/component_param.go 98.13% <85.71%> (ø)
... and 1 more

... and 14 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2023

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@cqy123456 cqy123456 force-pushed the binlog-index-test branch 2 times, most recently from b8e50b3 to 94aa016 Compare October 17, 2023 21:46
@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2023

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@cqy123456 cqy123456 force-pushed the binlog-index-test branch 2 times, most recently from e2081fd to 38509a3 Compare October 18, 2023 03:58
@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2023

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@cqy123456
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Oct 24, 2023

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 26, 2023

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@cqy123456 cqy123456 force-pushed the binlog-index-test branch 2 times, most recently from ef03273 to 9fd0f04 Compare October 29, 2023 16:36
@mergify mergify bot added the ci-passed label Oct 29, 2023
@xige-16
Copy link
Contributor

xige-16 commented Oct 30, 2023

/lgtm

@mergify
Copy link
Contributor

mergify bot commented Oct 31, 2023

@cqy123456 ut workflow job failed, comment rerun ut can trigger the job again.

@cqy123456
Copy link
Contributor Author

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Oct 31, 2023

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@cqy123456
Copy link
Contributor Author

/run-cpu-e2e

@cqy123456
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Oct 31, 2023
@xige-16
Copy link
Contributor

xige-16 commented Oct 31, 2023

/lgtm

@jiaoew1991
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cqy123456, jiaoew1991

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants